Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tw`` to an element for the first time causes the extension to become unresponsive #2

Closed
timfee opened this issue Aug 29, 2020 · 4 comments

Comments

@timfee
Copy link

timfee commented Aug 29, 2020

See attached video (and CPU dump), basically, I'm forced to reload the window any time I try to add a new tw=`` tag to an element inside of a .tsx file.

  1. Create a new element with the css prop, such as <span css={tw`m-0`}>
  2. Autocomplete doesn't load, and attempting to apply all fixes hangs, forcing a window reload.
  3. If you cancel the pending fix, save anyway, reload the window, and resume editing the new element, autocomplete becomes available and things function normally.

Does this appear to be related to this extension?

CPU dump: Arthie.vscode-tailwindcssinjs-unresponsive.cpuprofile.txt

Repro .MOV: Repro Steps.mov.zip

My extension list:

andrewmcodes.tailwindcss-extension-pack-1.0.0/
arthie.vscode-tailwindcssinjs-0.1.3/
austenc.tailwind-docs-1.3.0/
bradlc.vscode-tailwindcss-0.4.3/
christian-kohler.npm-intellisense-1.3.0/
christian-kohler.path-intellisense-2.2.1/
codeandstuff.package-json-upgrade-1.2.0/
coenraads.bracket-pair-colorizer-1.0.61/
coenraads.bracket-pair-colorizer-2-0.2.0/
davidanson.vscode-markdownlint-0.36.3/
dbaeumer.vscode-eslint-2.1.8/
deepscan.vscode-deepscan-1.10.2/
eamodio.gitlens-10.2.2/
ecmel.vscode-html-css-0.2.3/
editorconfig.editorconfig-0.15.1/
eg2.vscode-npm-script-0.3.13/
esbenp.prettier-vscode-5.5.0/
fallenmax.styled-components-extractor-0.0.6/
github.vscode-pull-request-github-0.19.0/
heybourn.headwind-1.7.0/
iocave.customize-ui-0.1.47/
iocave.monkey-patch-0.1.10/
jpoissonnier.vscode-styled-components-0.0.30/
kettanaito.nako-0.1.2/
luyizhi.vscode-graphql-0.0.4/
macieklad.tailwind-sass-syntax-1.2.1/
muhajirdev.tailwind-styled-snippets-0.2.1/
muhajirframe.tailwind-styled-snippets-0.2.1/
oderwat.indent-rainbow-7.4.0/
prisma.vscode-graphql-0.3.1/
rbbit.typescript-hero-3.0.0/
redhat.vscode-yaml-0.10.1/
richie5um2.vscode-sort-json-1.18.0/
ritwickdey.liveserver-5.6.1/
shardulm94.trailing-spaces-0.3.1/
steoates.autoimport-1.5.3/
stylelint.vscode-stylelint-0.85.0/
tht13.html-preview-vscode-0.2.5/
visualstudioexptteam.vscodeintellicode-1.2.10/
wallabyjs.quokka-vscode-1.0.315/
wwm.better-align-1.1.6/
yummygum.city-lights-icon-vsc-1.1.3/
yummygum.city-lights-theme-1.1.8/
@Arthie
Copy link
Owner

Arthie commented Aug 31, 2020

Hello Tim, thanks for the excellent report! I was able to reproduce the issue.
Please try updating the extension to the latest release (v0.1.5).

Removing ` from CompletionItemProvider trigger characters fixed the issue.

@mugoosse
Copy link

mugoosse commented Sep 1, 2020

@Arthie fyi your latest commit ('solving' this issue) introduces a very unpleasant UX change that took me hours to track down. See below:

Large GIF (810x528)

To get rid of it, I had to disable the plugin. I can imagine other people encountering the same issue as me so it might be good publishing a new version reverting this change for now.

@Arthie
Copy link
Owner

Arthie commented Sep 2, 2020

@mugoosse Thank you for taking the time to find this issue. So sorry for the inconvenience! v0.1.6 fixes both issues!

@timfee
Copy link
Author

timfee commented Sep 2, 2020

Thanks @Arthie :)

@Arthie Arthie closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants