Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/sidebar): show env variables in sidebar settings ui (#946) #956

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

qwqcode
Copy link
Member

@qwqcode qwqcode commented Aug 19, 2024

image

This PR updates the artalk settings interface to display configuration values set via environment variables with a "Controlled by environment variables; cannot be modified" message. Since environment variables take priority over configuration files, the graphical interface will prevent changes to these variables. The interface will only allow modifications to configuration file settings, keeping environment variable settings read-only and consistent.

More details here.

@qwqcode qwqcode merged commit 4d7e157 into master Aug 19, 2024
10 checks passed
@qwqcode qwqcode deleted the fix/ui/sidebar branch August 19, 2024 08:27
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.55%. Comparing base (587523f) to head (c56bbc7).
Report is 6 commits behind head on master.

Files Patch % Lines
server/handler/setting_get.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
- Coverage   31.63%   31.55%   -0.09%     
==========================================
  Files         204      204              
  Lines        8690     8694       +4     
==========================================
- Hits         2749     2743       -6     
- Misses       5790     5798       +8     
- Partials      151      153       +2     
Flag Coverage Δ
go 31.55% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

环境变量配置后,网页后台仍然是配置文件中的数据而不是环境变量
1 participant