This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
Incorrect title #185
Merged
Incorrect title #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only first word cap'ed
Incorrect title
|
First pull request (and what a monumental one) - sorry if I messed up. |
|
no problem! Fix the tests, too! :) |
Only first word cap'ed
|
hmm - the new commit was automagically added to the existing pr? I have to study this PR stuff. Have I just started my career as Open Source Developer? |
|
Yes you have! Thanks for your contribution! |
|
Added this fix to the Swift version as well: https://github.com/ArtSabintsev/Siren/releases/tag/3.1.7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only first word should be cap'ed