This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
Add Ukrainian localization #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you also update the Tests? |
|
@ArtSabintsev updated the Tests target but buddybuild CI failing in Xcode 8.3.1 on '@available' operator, which was introduced later. |
|
Alright, updated to Xcode 9 in BB for this branch. |
ArtSabintsev
suggested changes
Oct 20, 2017
| @@ -486,6 +486,15 @@ - (void)testTurkishLocalization { | |||
| XCTAssertTrue([[_harpy testLocalizedStringForKey:@"Update"] isEqualToString:@"Güncelle"]); | |||
| } | |||
|
|
|||
| - (void)testUkrainianLocalization { | |||
| [_harpy setForceLanguageLocalization:HarpyLanguage]; | |||
There was a problem hiding this comment.
This should be HarpyLanguageUkranian.
There was a problem hiding this comment.
Fixed mistyped constant.
ArtSabintsev
approved these changes
Oct 20, 2017
|
This is live - https://github.com/ArtSabintsev/Harpy/releases/tag/4.1.8 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.