Release #99
Merged
Release #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing some not updated info in README.md and removing unnecesary commands from the actions
Adding the .env to the service deployment
Little fixes into the README.md and deploy.yml to tear-down the containers correctly
- Included an openapi.yaml file with the v0.2.0 of the specification - Some changes in the gateway.js to create the swagger sever - Added --pull always option to the README
* Sync package-lock.json
- Reemplace the host IP for production in the specification file - Changed the routes to avoid Fnotfound during the E2E test suite execution
Configuración del fin de partida, CSS de las pantallas
Documentación, filtro de peticiones y post cambiados por gets
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| app.get('/getgamehistory/:username', async (req, res) => { | ||
| try { | ||
| const username = req.params.username; | ||
| const userResponse = await axios.get(`${userServiceUrl}/getgamehistory/${username}`); |
Check warning
Code scanning / SonarCloud
Server-side requests should not be vulnerable to forging attacks
|
| app.get('/getgamehistory/:username', async (req, res) => { | ||
| try { | ||
| const username = req.params.username; | ||
| const userResponse = await axios.get(`${userServiceUrl}/getgamehistory/${username}`); |
Check warning
Code scanning / SonarCloud
Server-side requests should not be vulnerable to forging attacks Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.