Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route sharing #116

Closed
Drastur opened this issue Mar 31, 2020 · 3 comments
Closed

Route sharing #116

Drastur opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed PRIO: High

Comments

@Drastur
Copy link
Contributor

Drastur commented Mar 31, 2020

Hi,
I'm taking a look to viadeSpec's issue concerning route sharing and I'm between two different aproaches:

User A wants to share a route to User B

Approach 1:
User A shares the route by creating a file in the /inbox folder of User's B pod. This file contains the URI of the route shared.

Drawbacks
The routes of userA have to be inside a folder where everyone has access, such as /public. Security problems might arise as you can create infinite files inside your friends inbox.

Approach 2:
User A shares the route of User's B pod. Then, you do the following:

  1. User A gives read permission to User B over the route shared.
  2. User A creates a file in it's own POD inside /viade/routes/shared called userBwebID.json in where you store the URI of the route shared. In case this file already exist, a new entry is added for the shared route's URI.
  3. User A gives User B read permissions over the json file.

Drawbacks
Im not sure by now on how to modify .acl files that give permission over folders and files, so further investigation is requiered.

@Drastur Drastur added enhancement New feature or request help wanted Extra attention is needed PRIO: High labels Mar 31, 2020
@jesQM
Copy link
Contributor

jesQM commented Mar 31, 2020

However, I believe following ViadeSpec will already decide for us this issue.
In order to read the routes, we all must write them in the same folder (either /viade or /public/viade), so depending on where the specification tells us to do so, we can already choose one approach or the other.
Not certain if I am correct, may easily be missing something.

@Drastur
Copy link
Contributor Author

Drastur commented Apr 1, 2020

Just implemented the "notification" part, but not sure on how can we modify permissions of a folder. Any suggestion?

@jesQM
Copy link
Contributor

jesQM commented Apr 2, 2020

#148 is taking care of the permissions issue, I will try to take care of it by:

  • Trying to edit the .acl files as a normal file
  • Trying external libraries that may help

Will post any further discovery in the other issue page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed PRIO: High
Projects
None yet
Development

No branches or pull requests

3 participants