Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Final delivery] Summary - Sebastian Lopez Hernandez (@sebaslh01) #182

Open
sebaslh01 opened this issue May 2, 2022 · 0 comments
Open
Assignees
Labels
peer assessment Tag used to identify the issues used for peers to asses our work.
Milestone

Comments

@sebaslh01
Copy link
Contributor

For this deliverable:

  • I was in charge of adapting the webapp to mobile devices, making the corresponding appropriate changes. In some cases I redistributed the display of everything, simulating a new view (for small screens)

  • I helped in the Unitary testing: made MainProducts.test.tsx and ProductPage.test.tsx, NavBar, AboutUs, part of AddressForm... I reviewed as well some of the other test made by my team mates.

  • I created the PageNotFound for URLs we don't handle.

  • I wrote the 13.1 part of the documentation 'Unitary test'.

  • I added a functionality that shows a message when components are being fetched from the DB and when they don't match a filtering criteria.

  • I reviewed several PR and tried to remove code smells.

  • @danieladov and I created the ratings functionality. Mostly done by him as he took care of all the backend.
    Links to corresponding issues /commits:

I reviewed the following PRs:

@UO258220 UO258220 added the peer assessment Tag used to identify the issues used for peers to asses our work. label May 3, 2022
@UO258220 UO258220 added this to the DeDe V3.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer assessment Tag used to identify the issues used for peers to asses our work.
Projects
None yet
Development

No branches or pull requests

2 participants