Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

fix: cypress verify failure #835

Merged
merged 4 commits into from
Jan 24, 2020
Merged

fix: cypress verify failure #835

merged 4 commits into from
Jan 24, 2020

Conversation

ItsANameToo
Copy link
Contributor

@ItsANameToo ItsANameToo commented Jan 24, 2020

Applies a workaround to hopefully have the cypress tests run again, based on cypress-io/cypress#6184 (comment)

They just released their new version, so updating to that will fix the issue

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jan 24, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #835 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #835   +/-   ##
========================================
  Coverage    41.52%   41.52%           
========================================
  Files          159      159           
  Lines         2981     2981           
  Branches       405      405           
========================================
  Hits          1238     1238           
  Misses        1743     1743
Flag Coverage Δ
#unittests 41.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444ba8a...16f9616. Read the comment docs.

@ItsANameToo ItsANameToo changed the title fix: add workaround for cypress tests to github workflow fix: cypress verify failure Jan 24, 2020
@ItsANameToo ItsANameToo merged commit 5687f31 into develop Jan 24, 2020
@ghost ghost deleted the fix/cypress branch January 24, 2020 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant