feat: openai streaming tool calls #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
axiomofjoy
commented
Dec 12, 2023
•
axiomofjoy
commented
- adds tool call support for synchronous and asynchronous streaming
- adds corresponding unit tests
axiomofjoy
force-pushed
the
openai-streaming-tool-calls
branch
from
f87d383 to
0be1a35
Compare
RogerHYang
approved these changes
Dec 14, 2023
RogerHYang
reviewed
Dec 14, 2023
RogerHYang
reviewed
Dec 18, 2023
Comment on lines
+650
to
+651
| for tool_call in choice.delta.tool_calls: | ||
| tool_index = tool_call.index |
There was a problem hiding this comment.
for extra safety?
Suggested change
| for tool_call in choice.delta.tool_calls: | |
| tool_index = tool_call.index | |
| for tool_index, tool_call in enumerate(choice.delta.tool_calls): |
RogerHYang
pushed a commit
that referenced
this pull request
Dec 19, 2023
- adds tool call support for synchronous and asynchronous streaming - adds corresponding unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.