-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make the app launchable when nest_asyncio is applied #1783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See alternate solution here.
Oh nice, yeah let's do that |
Though it seems like there is a performance hit
|
True, but the server is not handling (hundreds of) thousands of requests/s, so it's probably an acceptable trade-off. |
720cad3
to
07faec5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Roger Yang <[email protected]>
resolves #1353
This resolves the issue that nest asyncio makes the application fail to launch. Many notebooks, including ones from llamaIndex, have nest_asyncio applied at the top. In these cases the server cannot crash. This makes it so that the server runs via the "asyncio" eventloop when it is applied.