Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unpin llama-index version in tutorial notebooks #1766

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

axiomofjoy
Copy link
Contributor

@axiomofjoy axiomofjoy commented Nov 16, 2023

  • unpinning all the notebooks so they run again
  • install llama-index via our phoenix extra to ensure version compatibility

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy
Copy link
Contributor Author

This issue is affecting other notebooks.

@axiomofjoy
Copy link
Contributor Author

axiomofjoy commented Nov 16, 2023

Assuming the underlying issue that caused us to pin the LlamaIndex notebook version been resolved: run-llama/llama_index#8791.

@axiomofjoy
Copy link
Contributor Author

axiomofjoy commented Nov 16, 2023

Seems like, even on the latest version of LlamaIndex, we are still seeing errors when using gcsfs to download the pre-built index. But the notebook still runs to completion. I am going to unpin the notebook LlamaIndex versions for now.

Screenshot 2023-11-16 at 10 50 56 AM

@axiomofjoy axiomofjoy changed the title fix: unpin llama-index version in llama_index_openai_agent_tracing_tutorial notebook fix: unpin llama-index version in tutorial notebooks Nov 16, 2023
@axiomofjoy axiomofjoy merged commit 5ff74e3 into main Nov 16, 2023
6 checks passed
@axiomofjoy axiomofjoy deleted the unpin-llama-index branch November 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants