Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Block so that output is always a str or None #8

Open
AlexWaygood opened this issue Aug 1, 2023 · 0 comments
Open

Refactor Block so that output is always a str or None #8

AlexWaygood opened this issue Aug 1, 2023 · 0 comments

Comments

@AlexWaygood
Copy link

Block.output is incredibly un-type-safe at the moment:

output: Any = None # TODO: Very dynamic; probably untypeable in its current form?

Most of the time, it's a str, but whenever we're inside one of the methods called by DSLParser.parse(), it's a list of strings. See my essay in python#106519 (comment) for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant