Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining undeclared portInputRegister and digitalPinToPort #208

Open
jgfoster opened this issue Nov 13, 2020 · 0 comments
Open

Remaining undeclared portInputRegister and digitalPinToPort #208

jgfoster opened this issue Nov 13, 2020 · 0 comments
Labels
arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures

Comments

@jgfoster
Copy link
Member

jgfoster commented Nov 13, 2020

This is a follow-up to #193. With that issue we have these identifiers declared for some platforms but there are others that do not yet work. To see this go to Arduino-CI/Adafruit_BusIO and remove (or rename) .arduino-ci.yml and run ./scripts/test.sh and you will see things like the following:

/Users/jfoster/Documents/Arduino/libraries/Adafruit_BusIO/src/Adafruit_SPIDevice.cpp:58:33: error: use of undeclared identifier 'portInputRegister'
    misoPort = (BusIO_PortReg *)portInputRegister(digitalPinToPort(misopin));

This issue is low priority (to the author!), but represents an issue that might arise for others so seems to warrant a record here.

@ianfixes ianfixes added arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures labels Nov 13, 2020
@ianfixes ianfixes added this to the Arduino library completeness milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino mocks Compilation mocks for the Arduino library bug Something isn't working some archs Only affects some Arduino architectures
Projects
None yet
Development

No branches or pull requests

2 participants