Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onchain: add maesarat end-to-end test #126

Closed
wants to merge 1 commit into from

Conversation

MatthewCroughan
Copy link
Contributor

@MatthewCroughan MatthewCroughan commented May 18, 2022

Adds a basic Maesarat end-to-end test which occurs in CI and can be ran via either of these two commands:

  • nix flake check
  • nix build .#checks.x86_64-linux.end-to-end

The usefulness of this is limited due to #103. Additionally, this function is very basic, and all it does is copy the test we did on DanaSwap, and put that code into Maesarat for boiler plate elimination. The future Maesarat will be full featured, so this is just a stopgap.

@MatthewCroughan MatthewCroughan requested a review from tbidne May 18, 2022 03:42
@MatthewCroughan MatthewCroughan requested review from delicious-lemon and a team as code owners May 18, 2022 03:42
@tbidne
Copy link
Contributor

tbidne commented May 18, 2022

This is pretty neat. Nice to see maesarat cleaned up as well, thanks for that. One question, does it make the most sense for this to be part of the onchain flake? The hello-world e2e is purely offchain, at the moment.

flake.nix Outdated
@@ -1,5 +1,6 @@
{
inputs = {
maesarat.url = "path:///home/matthew/git/platonic/Maesarat";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work, where we refer to a specific path? I don't have the same code on the same path.

Copy link
Contributor

@nixinator nixinator May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks going to be need to redirected to networked git repo, if has state that is generated after cloning, then it's going to be need to point to that state on your machine, which will be a file path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I forgot to update the URL when testing it.

Adds a basic maesarat end-to-end test which occurs in CI and can be ran
via 'nix flake check' or 'nix build .#checks.x86_64-linux.end-to-end
@MatthewCroughan
Copy link
Contributor Author

This is no longer needed due to #141, since the tests are now ran in the Nix sandbox rather than a VM Test.

@MatthewCroughan MatthewCroughan deleted the mc/simple-maesarat branch May 30, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants