Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello World Offchain Backend CORS #104

Closed
tbidne opened this issue May 10, 2022 · 1 comment · Fixed by #122
Closed

Hello World Offchain Backend CORS #104

tbidne opened this issue May 10, 2022 · 1 comment · Fixed by #122
Labels
bug Something isn't working

Comments

@tbidne
Copy link
Contributor

tbidne commented May 10, 2022

Currently, sending requests to the backend server from the browser hits a CORS error. This needs to be fixed.

Strictly speaking, this isn't directly blocked by #103. However it is effectively blocked, as the endpoints are useless until that is fixed.
@tbidne tbidne added bug Something isn't working blocked This issue is blocked labels May 10, 2022
@tbidne tbidne self-assigned this May 10, 2022
@tbidne tbidne removed the blocked This issue is blocked label May 16, 2022
@tbidne
Copy link
Contributor Author

tbidne commented May 16, 2022

I was too pessimistic about labeling this blocked. Even if the interesting endpoints don't work, we can still use others (e.g. healthcheck) to test the CORS issue. Thus it makes sense to fix this now if we can.

@tbidne tbidne mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix browser CORS blocking ArdanaLabs/dUSD
1 participant
@tbidne