Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flake8/isort/black with ruff #33

Closed
Archmonger opened this issue Sep 18, 2024 · 2 comments · Fixed by #37
Closed

Replace flake8/isort/black with ruff #33

Archmonger opened this issue Sep 18, 2024 · 2 comments · Fixed by #37

Comments

@Archmonger
Copy link
Owner

Archmonger commented Sep 18, 2024 •
edited
Loading

Description

We currently use flake8/isort/black since that was what our upstream (WhiteNoise) uses, but we should replace it with the more sane/performant ruff linter when possible.
@stumpylog
Copy link
Contributor

Since hatch is in now, ruff linting and formatting is basically built in with hatch fmt and hatch fmt --check. And since ruff follows pyproject configuration, easy to configure it fully there or accept the hatch defaults.

@Archmonger Archmonger mentioned this issue Sep 18, 2024
Merged
4 tasks
@Archmonger
Copy link
Owner Author

As a note, I'd like resolving this ticket to involve a VsCode profile and editor.config file with sane defaults.

@Archmonger Archmonger linked a pull request Sep 21, 2024 that will close this issue
Docs updates, run precommit.ci, and use Ruff #37
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs updates, run precommit.ci, and use Ruff Archmonger/ServeStatic
2 participants
@stumpylog @Archmonger