Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pokemon Emerald: Remove README #3532

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Pokemon Emerald: Remove README #3532

merged 1 commit into from
Jun 15, 2024

Conversation

Zunawe
Copy link
Collaborator

@Zunawe Zunawe commented Jun 14, 2024

What is this fixing or adding?

Information that used to be in here was moved into docs/. Version number being in here and CHANGELOG only really makes it a pain to keep them in line with each other.

How was this tested?

N/A

@github-actions github-actions bot added is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 14, 2024
@Zunawe Zunawe added is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed is: documentation Improvements or additions to documentation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 14, 2024
nicholassaylor
nicholassaylor approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no reason to keep this file around anymore

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jun 14, 2024
Exempt-Medic
Exempt-Medic approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NewSoupVi NewSoupVi merged commit 0354315 into ArchipelagoMW:main Jun 15, 2024
11 checks passed
sflavelle pushed a commit to sflavelle/Archipelago-tgc that referenced this pull request Jun 20, 2024
@Zunawe @sflavelle
Pokemon Emerald: Remove README (ArchipelagoMW#3532)
da772d5
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@Zunawe @qwint
Pokemon Emerald: Remove README (ArchipelagoMW#3532)
694ad55
GameWyrm pushed a commit to GameWyrm/Archipelago-GW that referenced this pull request Jul 4, 2024
@Zunawe @GameWyrm
Pokemon Emerald: Remove README (ArchipelagoMW#3532)
75bd5d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholassaylor nicholassaylor nicholassaylor approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@NewSoupVi NewSoupVi NewSoupVi approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zunawe @NewSoupVi @Exempt-Medic @nicholassaylor