Setup: update cx_freeze to latest 6.x and exclude 7.x #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.x has a breaking API change for us, so that needs to be resolved separately.
github-actions
bot
added
affects: core
black-sliver
added
is: bug/fix
Berserker66
approved these changes
Apr 22, 2024
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…3194) 7.x has a breaking API change for us, so that needs to be resolved separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Disable upgrade to cx_freeze 7.x since that is incompatible for the way we hook into the build process. Also update to latest 6.x while at it.
Important: CI release action for Linux will fail if neither this nor #3195 is merged.
How was this tested?
python setup.py build_exe bdist_appimage