SC2: Remove the deprecated data version attribute in order to avoid cached old item names #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
alwaysintreble
added
the
is: bug/fix
Ziktofel
changed the title
Exempt-Medic
approved these changes
Mar 28, 2024
alwaysintreble
approved these changes
Mar 29, 2024
Exempt-Medic
added
waiting-on: core-review
|
Who still had the old name? To my knowledge that should only be Minecraft, if there's more out there I'd need to know. |
|
It appeared during RC1 stages inside SC2 client |
|
That's very odd. |
Berserker66
approved these changes
Apr 13, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
…ached old item names (ArchipelagoMW#3040)
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
…ached old item names (ArchipelagoMW#3040)
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…ached old item names (ArchipelagoMW#3040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Remove the deprecated data package version in order to avoid cached old item names
Some ppl got old
+15 Starting Mineralsinstead of modernAdditional Starting Mineralsin received item messages as the amount is configurable now.See: https://discord.com/channels/731205301247803413/980554570075873300/1222598200607903744
How was this tested?
Bumped the number as the world doc says. However, the world name has changed too and the old apworld could remain on the RC website
If this makes graphical changes, please attach screenshots.