[ALTTP] Add second Power Star to differentiate non-native progression items #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the alttp basepatch to add item ID 0x69 for advancement items from other worlds, and adds the corresponding item and sprite handling to allow displaying gold power stars for advancement/progression items from other worlds and silver power stars for other items. The basepatch was generated from krelbel/z3randomizer@91c3dd6 Example image: https://i.imgur.com/B2LUdFS.png
This change updates the gold/silver power star item names to be consistent with the final planned behavior of progression items being gold and all other items being silver, and imports a new basepatch based on ArchipelagoMW/z3randomizer@b787b83 which fixes a bug in the previous commit where the silver power star item in newitems.asm:.properties still used the gold power star palette, causing the "item get" animation to incorrectly show a gold power star upon picking up a silver power star. Tested with a 2-player lttp/hollowknight multiworld verifying standing items look correct in and out of shops and picking up items animates correctly for both gold and silver power stars. The previous commit listed an outdated screenshot (with the colors reversed); the updated screenshot showing this feature is: https://i.imgur.com/iMPxzgw.png
Fix outdated comment
Update the LTTP basepatch to include recent additions for "Bomb Bag" setting, alongside our Silver Power Star adjustments.
Allow players to opt out of seeing non-progression items as Silver Stars, through a new YAML option.
The wording of the comments in the get_nonnative_item_sprite function was a little confusing, making it sound like the vote mentioned there was for Gold vs. Silver Power Stars, when it's actually for using Power Stars as a whole. This text has been clarified.
github-actions
bot
added
the
waiting-on: peer-review
|
This is an update/extension of #2139 created with permission from the original developer. |
ScipioWright
added
the
is: enhancement
|
Just confirming here, as the original developer, I fully approve of this change. Thanks for taking care of this Kappa! I'm really excited to see this finally committed. (If everyone's okay with this, then I'll happily close my original PR that I reopened to make my intentions clear.) |
An update was made to the basepatch to correct a calculation. This commit updates the basepatch to include that correction alongside the Silver Star adjustments.
Exempt-Medic
approved these changes
Jul 28, 2024
Exempt-Medic
added
waiting-on: world-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This change updates the ALTTP base patch to add item ID 0x69 for advancement items from other worlds, and adds the corresponding item and sprite handling to allow displaying gold power stars for advancement/progression items from other worlds and silver power stars for other items. A new option, "Star Scams," is added to allow players to opt out of this adjustment and have all non-native items appear as gold power stars, whether they're progression items or not.
New base patch was generated from ArchipelagoMW/z3randomizer#9 after updating it to include recent "Bombless" functionality.
How was this tested?
Multiworlds were generated using ALTTP and several copies of Bumper Stickers, with Star Scams set On for some, Off for others. A number of locations were checked to ensure that the Power Star graphics matched expectations, and the items behaved appropriately.
If this makes graphical changes, please attach screenshots.