Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Options, More Docs, More Tests #51

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

massimilianodelliubaldini
Copy link
Collaborator

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

  • New Player Options:
    • Enable Reordering of Power Cell Thresholds into Ascending Order (useful for those who like to randomize cell counts, but still want them to step upward in each hub area).
    • Require Punch for Klaww (useful for those who don't like (or don't know about) shooting yellow eco with the goggles).
  • Updated documentation to remove all references to an APWORLD, in preparation for merge to upstream.
  • More Unit Tests
    • Tests for Move Rando
    • Tests for Orbsanity
    • Tests for Trades
    • Tests for Ordered Cell Counts

How was this tested?

Running the unit tests, reading the docs in formatted markdown, running some generation tests with singleplayer and multiplayer, completing Geyser Rock to ensure no client-side errors.

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review clone of upstream label label Sep 15, 2024
@t-rbernard
Copy link

Looked through the code and ran a few generations with and without the new options enabled, looking through the spoiler log after for sanity check and all seems good

@massimilianodelliubaldini massimilianodelliubaldini merged commit e0410ea into main Sep 17, 2024
27 checks passed
@massimilianodelliubaldini
Copy link
Collaborator Author

Merge now, cut new apworld this weekend: a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on: peer-review clone of upstream label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants