Fix some documentation and names #80
Labels
help wanted
Requires contributor help to solve.
priority: normal
Normal priority
status: confirmed
Approved / validated
type: documentation
Changes to the documentation
type: improvement
A feature is added or adjusted
In the description of this entry of FEATURE_NOT_SUPPORTED it is said
yet NonPlayerAccounts are no longer an optional feature
In
Acount#setBalance
it is saidyet the provider may optionally support negative balances (
OptionalEconomyApiFeature#NEGATIVE_BALANCES
)We have 2 packages for common clases between APIs:
me.lokka30.treasury.api.common
andme.lokka30.treasury.api.misc
There are most likely some more inconcistencies in the code/documentation but these are the ones that I had time to find. We should probably do a full scan of the code after the PR are closed to find these mistakes
EDIT: some more things I found
EconomyFailureReason#ACCOUNT_DELETION_NOT_SUPPORTED
but account deletion is not an optional featureEconomyFailureReason#ALREADY_MEMBER_OF_ACCOUNT
andEconomyFailureReason#ALREADY_NOT_MEMBER_OF_ACCOUNT
but we no longer have anaddMember
method, members now are defined by permissionsEconomyFailureReason#ALREADY_OWNER_OF_ACCOUNT
andEconomyFailureReason#ALREADY_NOT_OWNER_OF_ACCOUNT
we no longer have ownersThe text was updated successfully, but these errors were encountered: