Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasury vs Vault: looking for your opinions #66

Closed
lokka30 opened this issue Dec 11, 2021 · 11 comments
Closed

Treasury vs Vault: looking for your opinions #66

lokka30 opened this issue Dec 11, 2021 · 11 comments
Assignees
Labels
priority: normal Normal priority status: confirmed Approved / validated thoughts wanted Thoughts from other developers would be appreciated on this issue. type: documentation Changes to the documentation

Comments

@lokka30
Copy link
Member

lokka30 commented Dec 11, 2021

Hi all,

I have finished my comparison of Vault, Reserve and Treasury on this Wiki page. Please tell me if you disagree with anything, I am only looking to make an accurate comparison.

I'll close this issue if there is no activity for a certain period.

Tagging users who may be interested:
@Jikoo @MrIvanPlays @Geolykt @MrNemo64 @NoahvdAa

@lokka30 lokka30 added type: documentation Changes to the documentation priority: normal Normal priority thoughts wanted Thoughts from other developers would be appreciated on this issue. status: confirmed Approved / validated labels Dec 11, 2021
@lokka30 lokka30 self-assigned this Dec 11, 2021
@MrIvanPlays
Copy link
Member

All good.

@MrNemo64
Copy link
Contributor

Treasury has the best documentation of the three projects. Vault's is okay, but it is also missing some key information. Reserve's Wiki is poor, but its javadocs are decent at least.

This doesnt seem to parse correctly
msedge_ShKRsoIImj

On the BankAccount section

Vault's bank accounts require an owner which is not suitable for all implementations. (...). Vault's require an owner.

Why say it twice?

That's all I could think of right now

@lokka30
Copy link
Member Author

lokka30 commented Dec 11, 2021

Treasury has the best documentation of the three projects. Vault's is okay, but it is also missing some key information. Reserve's Wiki is poor, but its javadocs are decent at least.

This doesnt seem to parse correctly msedge_ShKRsoIImj

On the BankAccount section

Vault's bank accounts require an owner which is not suitable for all implementations. (...). Vault's require an owner.

Why say it twice?

That's all I could think of right now

Thanks, will edit now.

@creatorfromhell
Copy link
Contributor

creatorfromhell commented Dec 11, 2021

Reserve should be removed from this list. It was never designed to be a long-lasting API and more of a stop-gap until something new came along. I think there's this misconception that it's Treasury going up against Vault and Reserve, while I'd rather have Treasury take over the battle because a) I've spent a total of 2 hours working on Reserve so it's not really going to be worth it anyways and b) it gives me more time to focus on better things than constantly responding to messages in regards to Reserve. I fully support Treasury and if it gets adoption I'll add support for it into TNE, but there's no real battle going on, because as I said, Reserve wasn't built to be a long-term API just a stop-gap until something new, or Vault adds the needed methods to their project for multi-currency support.

@lokka30
Copy link
Member Author

lokka30 commented Dec 11, 2021

Reserve should be removed from this list. It was never designed to be a long-lasting API and more of a stop-gap until something new came along. I think there's this misconception that it's Treasury going up against Vault and Reserve, while I'd rather have Treasury take over the battle because a) I've spent a total of 2 hours working on Reserve so it's not really going to be worth it anyways and b) it gives me more time to focus on better things than constantly responding to messages in regards to Reserve. I fully support Treasury and if it gets adoption I'll add support for it into TNE, but there's no real battle going on, because as I said, Reserve wasn't built to be a long-term API just a stop-gap until something new, or Vault adds the needed methods to their project for multi-currency support.

Thanks for the clarification, I assumed it would be a long-term API. Reserve will not be referenced anywhere on Treasury's pages now. 👍🏻

@lokka30 lokka30 changed the title Treasury vs Vault vs Reserve: looking for your opinions Treasury vs Vault: looking for your opinions Dec 11, 2021
@lokka30
Copy link
Member Author

lokka30 commented Dec 12, 2021

I am satisfied with the state of the page so I will close this issue. Feel free to leave any more comments, I am just discarding it from our priorities.

@lokka30 lokka30 closed this as completed Dec 12, 2021
@MrNemo64
Copy link
Contributor

There is a typo at the bank account section

reasury's bank accounts have none of these issues.

@lokka30
Copy link
Member Author

lokka30 commented Dec 12, 2021

There is a typo at the bank account section

reasury's bank accounts have none of these issues.

Good catch! I also found I did not mention the bank permissions system. Fixed both 👍

@creatorfromhell
Copy link
Contributor

Reserve should be removed from this list. It was never designed to be a long-lasting API and more of a stop-gap until something new came along. I think there's this misconception that it's Treasury going up against Vault and Reserve, while I'd rather have Treasury take over the battle because a) I've spent a total of 2 hours working on Reserve so it's not really going to be worth it anyways and b) it gives me more time to focus on better things than constantly responding to messages in regards to Reserve. I fully support Treasury and if it gets adoption I'll add support for it into TNE, but there's no real battle going on, because as I said, Reserve wasn't built to be a long-term API just a stop-gap until something new, or Vault adds the needed methods to their project for multi-currency support.

Thanks for the clarification, I assumed it would be a long-term API. Reserve will not be referenced anywhere on Treasury's pages now. 👍🏻

While it does occasionally get updates, no it's not designed to be a long-term API currently.

@MrIvanPlays
Copy link
Member

Reserve should be removed from this list. It was never designed to be a long-lasting API and more of a stop-gap until something new came along. I think there's this misconception that it's Treasury going up against Vault and Reserve, while I'd rather have Treasury take over the battle because a) I've spent a total of 2 hours working on Reserve so it's not really going to be worth it anyways and b) it gives me more time to focus on better things than constantly responding to messages in regards to Reserve. I fully support Treasury and if it gets adoption I'll add support for it into TNE, but there's no real battle going on, because as I said, Reserve wasn't built to be a long-term API just a stop-gap until something new, or Vault adds the needed methods to their project for multi-currency support.

Thanks for the clarification, I assumed it would be a long-term API. Reserve will not be referenced anywhere on Treasury's pages now. 👍🏻

While it does occasionally get updates, no it's not designed to be a long-term API currently.

Looks more like an API which is made for private use rather than an actual API. No bad feelings though.

@lokka30
Copy link
Member Author

lokka30 commented Dec 14, 2021

@MrIvanPlays

It was never designed to be a long-lasting API and more of a stop-gap until something new came along.

🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Normal priority status: confirmed Approved / validated thoughts wanted Thoughts from other developers would be appreciated on this issue. type: documentation Changes to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants