Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Treasury's code into modules #42

Closed
lokka30 opened this issue Oct 26, 2021 · 2 comments · Fixed by #45
Closed

Split Treasury's code into modules #42

lokka30 opened this issue Oct 26, 2021 · 2 comments · Fixed by #45
Assignees
@lokka30
Labels
help wanted Requires contributor help to solve. priority: high High priority status: confirmed Approved / validated status: on hold Development is paused until further notice thoughts wanted Thoughts from other developers would be appreciated on this issue. type: improvement A feature is added or adjusted

Comments

@lokka30
Copy link
Member

lokka30 commented Oct 26, 2021

I believe this was discussed in #37.
This issue will be on hold until #37 is completed.

I haven't used modules before, I might need pointers here. I'm also very interested to hear what modules developers think Treasury should have. I'm thinking:

  • treasury-api
  • treasury-plugin-bukkit, treasury-plugin-sponge, etc
@lokka30 lokka30 added type: improvement A feature is added or adjusted help wanted Requires contributor help to solve. status: on hold Development is paused until further notice priority: high High priority thoughts wanted Thoughts from other developers would be appreciated on this issue. status: confirmed Approved / validated labels Oct 26, 2021
@lokka30 lokka30 self-assigned this Oct 26, 2021
@MrIvanPlays
Copy link
Member

I haven't used modules before, I might need pointers here.

The reason why Pull requests and contributing exists is to show the code owner that there is an easier or a better way of doing operation x. I can do this but I don't want to do anything until PR 37 is merged.

@MrNemo64
Copy link
Contributor

I believe this was discussed in #37.

Indeed,
#37 (comment)

@MrIvanPlays MrIvanPlays mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokka30 lokka30

Labels
help wanted Requires contributor help to solve. priority: high High priority status: confirmed Approved / validated status: on hold Development is paused until further notice thoughts wanted Thoughts from other developers would be appreciated on this issue. type: improvement A feature is added or adjusted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Treasury's code into modules MrIvanPlays/Treasury
3 participants
@MrIvanPlays @MrNemo64 @lokka30