Feature/customized webpack plugin integration #2
Commits on Jul 18, 2019
-
Fix CI issue on windows (facebook#7385)
* Attempt at fixing CI issue on windows * Try to debug why verdaccio isn't in the ps output * Just remove the kill call alltogether
-
This closes facebook#7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining. We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit". The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us: - minimum node version is 8.9.x, we already require 8.10.x - the limit was "greater than", is now "greater than or equal to"
-
Merge pull request facebook#7378 from heyimalex/update_url_loader
Update url-loader to 2.0.1
Commits on Jul 22, 2019
Commits on Jul 25, 2019
-
Add question issue template (facebook#7423)
* Add question issue template * Fix bug report template formatting * Fix bug report template formatting * Add labels to pull request template
-
Update deploy instructions in contributing guide (facebook#7429)
* Update deploy instructions in contributing guide * Update docs publishing instructions
-
Commits on Jul 26, 2019
Commits on Jul 28, 2019
Commits on Jul 29, 2019
Commits on Jul 30, 2019
Commits on Aug 1, 2019
-
Improve bootstrap docs when using custom SCSS (facebook#7462)
* Added dependencies to bootstrap article when using custom SCSS. * Make changes to package designation and added npm install directions.
Commits on Aug 4, 2019
Commits on Aug 5, 2019
Commits on Aug 6, 2019
-
Resolve relative paths for preprocessor styles (facebook#5829)
preprocessor will output sourceMap by default then check if sourceMaps are needed on resolve-url-loader Fixes facebook#4653
Commits on Aug 7, 2019
Commits on Aug 8, 2019
-
Adjusted deployment documentation for ZEIT Now (facebook#7488)
* Adjusted deployment documentation for ZEIT Now * Fixed missing word * Update docusaurus/docs/deployment.md Co-Authored-By: Joe Haddad <[email protected]>
-
-
Fix RegExp from navigateFallbackBlacklist (workbox) (facebook#7176)
Exclude URLs that contains a "?" character.
-
-
Commits on Aug 9, 2019
-
-
-
Remove unused dependencies in babel-preset-react-app (facebook#5818)
* Remove unused dependencies in babel-preset-react-app * Re-add @babel/plugin-transform-react-display-name * Remove some dependencies again
-
-
Commits on Aug 12, 2019
Commits on Aug 13, 2019
-
-
-
Fix ESLint 6 support (facebook#7513)
* Remove extends restriction to fix ESLint 6 support * Attempt to resolve CI errors
-
-
Commits on Aug 14, 2019
-
Show logo on mobile docs (facebook#7521)
* Show logo for mobile views in create-react-app.dev * Update docusaurus/website/static/css/custom.css Co-authored-by: Sabesh Kumar Rajendran <[email protected]>
Commits on Aug 16, 2019
-
Add a migration step to remove static directory from robots.txt (face…
…book#7536) * add a migration step to remove static from robots.txt * Update CHANGELOG.md Co-Authored-By: Ian Sutherland <[email protected]>
-
docs: update Flow documentation (facebook#7550)
* docs: update Flow documentation * Update adding-flow.md * Update adding-flow.md
Commits on Aug 19, 2019
Commits on Aug 23, 2019
Commits on Aug 30, 2019
Commits on Sep 2, 2019
-
Remove cleanup-after-each example (facebook#7620)
cleanup is called now by default after each test if the testing framework supports the afterEach global
Commits on Sep 6, 2019
-
Adopt Contributor Covenant (facebook#7650)
* Adopt Contributor Covenant * Add link to Contributor Covenant to docs site
Commits on Sep 9, 2019
Commits on Sep 11, 2019
-
-
-
Minor performance improvements (facebook#7587)
- use ESLint cache - remove useless `watch` option in fork-ts-checker
Commits on Sep 13, 2019
Commits on Sep 14, 2019
Commits on Sep 17, 2019
-
Update deployment.md with another AWS example (facebook#7616)
Add blog post that takes a React developer step-by-step through many features of AWS. Blog post is suitable for a beginner to follow and have a production ready workflow.
Commits on Sep 19, 2019
Commits on Sep 20, 2019
Commits on Sep 24, 2019
Commits on Sep 25, 2019
Commits on Sep 26, 2019
Commits on Sep 27, 2019
Commits on Oct 1, 2019
Commits on Oct 3, 2019
-
Support production profiling with React Developer Tools (facebook#7737)
* Added the alias for profiling and output change to keep the classNames and functionNames for human readbility * defined isEnvProductionProfile with other isEnv checks * moved the keep_classnames and keep_fnames to terserOptions scope * resolve merge conflict for yarn.lock.cache * revert yarn.lock.cache to master yarn.lock.cache - git checkout origin/master -- packages/create-react-app/yarn.lock.cached * Comment and Boolean Check - I clarified the comment and specified the use case - Changed the environment check to check for the specific true rather than the assumed primitive value as before. * Replaced env with flag - Per suggestion --profile flag used instead of env variable PROFILE_APP * documentation in available scripts section with suggested information * resolved a local git issue. Fixed documentation error. * moved documentation to suggested file - Added a brief summary of profiling in available scripts section. The summary references the production-build document. Which is the file I moved the new documentation into under a new Header for production support. * Update production-build.md Co-authored-by: Ian Sutherland <[email protected]>
-
-
-
Commits on Oct 6, 2019
Commits on Oct 10, 2019
Commits on Oct 11, 2019
Commits on Oct 13, 2019
Commits on Oct 14, 2019
Commits on Oct 15, 2019
-
-
Upgrade to docusaurus 2 (facebook#7785)
* chore: upgrade to docusaurus 2 * address review
-
Commits on Oct 16, 2019
-
-
-
Link to React documentation for code splitting (facebook#7686)
The official documentation offers a simpler way of achieving route based code splitting.
Commits on Oct 17, 2019
-
added check for typescript template and unsupported node version (fac…
…ebook#7839) * added check for typescript template and unsupported node version * addressed code review feedback regarding syntax and spelling mistakes
Commits on Oct 18, 2019
-
Update getting-started.md (facebook#7841)
Update the initial project structure generated by create-react-app.
Commits on Oct 19, 2019
Commits on Oct 20, 2019
Commits on Oct 21, 2019
Commits on Oct 22, 2019
Commits on Oct 23, 2019
-
-
Add Service-Worker header to checkValidServiceWorker (facebook#6753)
* Add header to checkValidServiceWorker (ts) * Add header to checkValidServiceWorker
-
Add additional information for postcss errors (facebook#6282) (facebo…
…ok#6352) * Add additional information for postcss errors * Add additional information for postcss errors (simplify) * Remove chunkname from postCSS compile error * Remove line number from postCSS compile error
Commits on Oct 24, 2019
-
-
Add Alex to lint documentation (facebook#7852)
* Add Alex to lint documentation * Attempt to trigger GitHub Action * Configure Alex and update docs * More docs updates
-
-
-
-
-
-
Add template support (facebook#7716)
* Add template support * Update templates version check * Update TypeScript template README
-
-
Commits on Oct 25, 2019
-
Upgrade packages and tweak config to adapt to new config format (face…
…book#7814) Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions.
Commits on Oct 29, 2019
Commits on Oct 30, 2019
Commits on Oct 31, 2019
Commits on Nov 3, 2019
Commits on Nov 5, 2019
-
fix seperators typo (facebook#7932)
Its the little things that makes the big difference! 😁 Thanks
Commits on Nov 6, 2019
Commits on Nov 7, 2019
Commits on Nov 9, 2019
Commits on Nov 10, 2019
Commits on Nov 13, 2019
-
Fix light background in docusaurus night mode (facebook#7936)
* Fix light background in docusaurus night mode Closes facebook#7930 * Rename lightBackground to gettingStartedSection
Commits on Nov 16, 2019
Commits on Nov 18, 2019
Commits on Nov 20, 2019
-
Override no-unused-expressions with the typescript-eslint version (fa…
…cebook#8003) Fixes issues with optional chaining
Commits on Nov 24, 2019
Commits on Nov 25, 2019
Commits on Nov 28, 2019
Commits on Nov 29, 2019
-
Update template docs (facebook#8050)
* Update template docs * Update custom-templates.md * Update custom-templates.md Co-authored-by: Ian Sutherland <[email protected]>
Commits on Dec 5, 2019
Commits on Dec 6, 2019
-
-
Remove error for @typescript-eslint/no-namespace (facebook#7803)
Declare namespaces are supported by babel now, and babel will throw with a nice error message for non-declare namespaces, so this rule is unnecessary. Closes facebook#7651.
Commits on Dec 9, 2019
-
-
-
-
Fix typo in comment:
?.is right, not.?(facebook#8124)This is just a comment fix. Actual optional chaining operator syntax is `?.`, not `.?`.
Commits on Dec 10, 2019
Commits on Dec 11, 2019
-
[Security] Update terser webpack plugin (facebook#8102)
* security: update terser webpack plugin
Commits on Dec 13, 2019
-
Add current version and bin location to --info output (facebook#8168)
Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules.
-
-
-
Commits on Dec 14, 2019
-
Bump internal dependencies (facebook#8176)
* Bump dependencies in react-dev-utils * Bump dependencies in react-app-polyfill * Bump dependencies in create-react-app * Bump dependencies in react-error-overlay * Bump dependencies in react-scripts * Bump react
Commits on Dec 15, 2019
-
Add package-runner note to readme (facebook#8132)
* Add package-runner note to readme * Add link to `yarn create`
Commits on Dec 16, 2019
-
Minor refactors in create-react-app (facebook#8178)
- Remove templates version minimum stopgap. - Replace indexOf with more idiomatic alternatives. - Inline errorLogFilePatterns. - Alphabetize validFiles. - Simplify log file removal code. - Move unconditional console.log() call outside of isSafe. - Differentiate conflicting directories from files. - Document yarn version special case. - Inline printValidationResults. - Standardize checkAppName output on failure. - Add link for checkThatNpmCanReadCwd. Functionally the code should be exactly the same.
Commits on Dec 18, 2019
Commits on Dec 19, 2019
Commits on Dec 20, 2019
Commits on Dec 30, 2019
-
Replace favicon in templates (facebook#8194)
The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors. Closes facebook#7957
Commits on Jan 12, 2020
Commits on Jan 16, 2020
Commits on Jan 21, 2020
Commits on Jan 22, 2020
-
Remove React.FC from Typescript template (facebook#8177)
This removes `React.FC` from the base template for a Typescript project. Long explanation for a small change: `React.FC` is unnecessary: it provides next to no benefits and has a few downsides. (See below.) I see a lot of beginners to TS+React using it, however, and I think that it's usage in this template is a contributing factor to that, as the prominence of this template makes it a de facto source of "best practice". ### Downsides to React.FC/React.FunctionComponent ##### Provides an implicit definition of `children` Defining a component with `React.FC` causes it to implicitly take `children` (of type `ReactNode`). It means that all components accept children, even if they're not supposed to, allowing code like: ```ts const App: React.FC = () => { /*... */ }; const Example = () => { <App><div>Unwanted children</div></App> } ``` This isn't a run-time error, but it is a mistake and one that would be caught by Typescript if not for `React.FC`. ##### Doesn't support generics. I can define a generic component like: ```ts type GenericComponentProps<T> = { prop: T callback: (t: T) => void } const GenericComponent = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` But it's not possible when using `React.FC` - there's no way to preserve the unresolved generic `T` in the type returned by `React.FC`. ```ts const GenericComponent: React.FC</* ??? */> = <T>(props: GenericComponentProps<T>) => {/*...*/} ``` ##### Makes "component as namespace pattern" more awkward. It's a somewhat popular pattern to use a component as a namespace for related components (usually children): ```jsx <Select> <Select.Item /> </Select> ``` This is possible, but awkward, with `React.FC`: ```tsx const Select: React.FC<SelectProps> & { Item: React.FC<ItemProps> } = (props) => {/* ... */ } Select.Item = (props) => { /*...*/ } ``` but "just works" without `React.FC`: ```tsx const Select = (props: SelectProps) => {/* ... */} Select.Item = (props) => { /*...*/ } ``` ##### Doesn't work correctly with defaultProps This is a fairly moot point as in both cases it's probably better to use ES6 default arguments, but... ```tsx type ComponentProps = { name: string; } const Component = ({ name }: ComponentProps) => (<div> {name.toUpperCase()} /* Safe since name is required */ </div>); Component.defaultProps = { name: "John" }; const Example = () => (<Component />) /* Safe to omit since name has a default value */ ``` This compiles correctly. Any approach with `React.FC` will be slightly wrong: either `React.FC<{name: string}>` will make the prop required by consumers, when it should be optional, or `React.FC<{name?: string}>` will cause `name.toUpperCase()` to be a type error. There's no way to replicate the "internally required, externally optional" behavior which is desired. ##### It's as long, or longer than the alternative: (especially longer if you use `FunctionalComponent`): Not a huge point, but it isn't even shorter to use `React.FC` ```ts const C1: React.FC<CProps> = (props) => { } const C2 = (props: CProps) => {}; ``` ### Benefits of React.FC ##### Provides an explicit return type The only benefit I really see to `React.FC` (unless you think that implicit `children` is a good thing) is that it specifies the return type, which catches mistakes like: ```ts const Component = () => { return undefined; // components aren't allowed to return undefined, just `null` } ``` In practice, I think this is fine, as it'll be caught as soon as you try to use it: ```ts const Example = () => <Component />; // Error here, due to Component returning the wrong thing ``` But even with explicit type annotations, `React.FC` still isn't saving very much boilerplate: ```ts const Component1 = (props: ComponentProps): ReactNode => { /*...*/ } const Component2: FC<ComponentProps> = (props) => { /*...*/ } ```
Commits on Jan 23, 2020
Commits on Jan 30, 2020
-
Remove outdated babel plugins (facebook#8353)
Updates dependencies and removes babel plugins that are now covered by `@babel/preset-env`. Co-authored-by: hdineen <[email protected]>
-
-
Update custom template docs with instructions for testing custom temp…
…late locally (facebook#8092) Co-authored-by: Ian Schmitz <[email protected]>
-
Update setting-up-your-editor.md (facebook#8247)
`Auto Fix is enabled by default. Use the single string form.` warning is shown in `.vscode/settings.json` due to changes in vscode-eslint. As autoFix is set to default, object format in `eslint.validate` is deprecated.
-
Remove outdated docs regarding vscode eslint extension and type… (fac…
…ebook#8307) Co-authored-by: Ian Schmitz <[email protected]>
-
-
Commits on Jan 31, 2020
-
-
-
docs: Add troubleshooting documentation on ENOSPC (facebook#8380)
Co-authored-by: Ian Schmitz <[email protected]>
-
-
-
-
Update commit message to use imperative mood (facebook#8377)
Why: * As per best practice: https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches#n135 See also: https://chris.beams.io/posts/git-commit/#imperative
-
fix(test): force install npm in e2e-behaviour (facebook#8402)
This will fix e2e-behaviour on macos Related: npm/cli#611 (comment)
-
setupTestFrameworkScriptFile is deprecated (facebook#8390)
* setupTestFrameworkScriptFile is deprecated __Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__ ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array * Update docusaurus/docs/running-tests.md Co-Authored-By: Simen Bekkhus <[email protected]> Co-authored-by: Simen Bekkhus <[email protected]>
-
-
Update public folder usage docs to clarify globals (facebook#8299)
Added the relevant topic linked directly, instead of saying it's just in the next section. Adjusted the text so it sounds more like a recommendation rather than a requirement. The topic linked is basically explainer to how you'd reference it using the global window object and ways to avoid linter errors. Thus I used 'reference' to give users a hint of what it the linked page would be for.
-
Support JetBrains Rider IDE as an editor (facebook#7948)
Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm.
-
Enable custom sockjs pathname for hot reloading server. (facebook#7750)
* Enable custom sockjs pathname for hot reloading server. * Update docusaurus/docs/advanced-configuration.md Co-Authored-By: Brody McKee <[email protected]> * let WDS_SOCKET_PATH be undefined * adding env variables for sockHost and sockPort options Co-authored-by: Brody McKee <[email protected]>
-
Add option to provide custom ssl certificates during development (fac…
…ebook#5845) * Add option to provide custom SSL certificates when using HTTPS * Update documentation with custom HTTPS certs * Improve certificate validation and move to its own file * Update https in development docs Co-Authored-By: Brody McKee <[email protected]> * Add custom cert example to docs * Rename https file and update error message * Include original error message when custom ssl cert is invalid * Add chalk to react-scripts dependencies * Bump docs version to say that the new config will be available in 3.2.0 * Remove chalk dependency * Update custom ssl version to 3.4.0 in docs * Remove version from custom ssl certificate docs Co-authored-by: Brody McKee <[email protected]>
-
Handle service worker error in Firefox (facebook#8272)
* Handle service worker error in Firefox See https://bugzilla.mozilla.org/show_bug.cgi?id=1429714 for more details. * Update serviceWorker.js
Commits on Feb 2, 2020
-
feat(react-scripts): allow PUBLIC_URL in develoment mode (facebook#7259)
Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]>
4 people authoredFeb 2, 2020
Commits on Feb 3, 2020
-
Change arrow functions to function declarations (facebook#8412)
- The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability.
Commits on Feb 6, 2020
Commits on Feb 8, 2020
-
Downgrade chalk for ie 11 support (facebook#8439)
* Downgrade chalk for ie 11 support * Update lockfile
-
fix(react-scripts): do not redirect served path if request may proxy (f…
…acebook#8442) Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes facebook#8417
Commits on Feb 10, 2020
Commits on Feb 11, 2020
Commits on Feb 13, 2020
-
Correct webpack name casing (facebook#8475)
webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding
Commits on Feb 14, 2020
Commits on Feb 19, 2020
-
-
Closes webpack dev server and exits process on "end" stdin (facebook#…
…7203) Co-authored-by: Ian Schmitz <[email protected]>
-
Widen eslint-config-react-app peer dependency versions (facebook#7790)
Co-authored-by: Ian Schmitz <[email protected]>
Commits on Feb 20, 2020
Commits on Mar 1, 2020
Commits on Mar 4, 2020
-
Fix proxying API request docs (facebook#8515)
The http-proxy-middleware package has made a major version upgraded and introduced a breaking change. This fixes the "Configuring the Proxy Manually" documentation to match the latest version.
Commits on Mar 9, 2020
Commits on Mar 10, 2020
-
Add React.StrictMode to default templates (facebook#8558)
Co-authored-by: Dan Abramov <[email protected]>
Commits on Mar 21, 2020
Commits on Mar 24, 2020
Commits on Mar 27, 2020
Commits on Apr 10, 2020
-
-
Merge branch 'feature/customizedWebpackPluginIntegration' of https://…
…github.com/ArbaazDossani/create-react-app into feature/customizedWebpackPluginIntegration
