Feature/customized webpack plugin integration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Attempt at fixing CI issue on windows * Try to debug why verdaccio isn't in the ps output * Just remove the kill call alltogether
This closes facebook#7359 by making IMAGE_INLINE_SIZE_LIMIT=0 actually disable image inlining. We use url-loader's `limit` option to set the line at which images will be inlined, and we basically expose this option to our end users via the IMAGE_INLINE_SIZE_LIMIT environment variable. Most people using it want to disable inlining images all together (the major motivator for adding it at all was I think for strict CSP), and our documentation said setting the value to zero would do that. However, it did the opposite: url-loader treated zero as "no limit". The update to 2.x fixes this; zero means nothing gets inlined. The other changes from the version bump shouldn't affect us: - minimum node version is 8.9.x, we already require 8.10.x - the limit was "greater than", is now "greater than or equal to"
Update url-loader to 2.0.1
* Add question issue template * Fix bug report template formatting * Fix bug report template formatting * Add labels to pull request template
* Update deploy instructions in contributing guide * Update docs publishing instructions
* Added dependencies to bootstrap article when using custom SCSS. * Make changes to package designation and added npm install directions.
preprocessor will output sourceMap by default then check if sourceMaps are needed on resolve-url-loader Fixes facebook#4653
* Adjusted deployment documentation for ZEIT Now * Fixed missing word * Update docusaurus/docs/deployment.md Co-Authored-By: Joe Haddad <[email protected]>
Exclude URLs that contains a "?" character.
* Remove unused dependencies in babel-preset-react-app * Re-add @babel/plugin-transform-react-display-name * Remove some dependencies again
Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]> Co-authored-by: Eric Clemmons <[email protected]> Co-authored-by: Alex Guerra <[email protected]> Co-authored-by: Kelly <[email protected]>
- The JavaScript template uses a function declaration to define the component, the TypeScript template and a page of the documentation used arrow functions. Changed it to use function declarations for consistency and readability.
* Downgrade chalk for ie 11 support * Update lockfile
…acebook#8442) Moved redirect middleware and noopSW middleware in WDS after hook So proxy, and before proxy will take precedence before redirect Closes facebook#8417
webpack should always be written in lower-case, according to webpack's branding guidelines https://webpack.js.org/branding
…7203) Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: Ian Schmitz <[email protected]>
The http-proxy-middleware package has made a major version upgraded and introduced a breaking change. This fixes the "Configuring the Proxy Manually" documentation to match the latest version.
Co-authored-by: Dan Abramov <[email protected]>
…github.com/ArbaazDossani/create-react-app into feature/customizedWebpackPluginIntegration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.