Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check SoilSkipListTest>>#testRemoveAllFromPage #850

Open
MarcusDenker opened this issue Oct 23, 2024 · 2 comments
Open

Check SoilSkipListTest>>#testRemoveAllFromPage #850

MarcusDenker opened this issue Oct 23, 2024 · 2 comments
Assignees
@MarcusDenker
Milestone
Index reuse of fr...

Comments

@MarcusDenker
Copy link
Contributor

SoilSkipListTest>>#testRemoveAllFromPage removes all items from a page, which we do not support (as we need a lowest key to search).

The test is green as SoilIndexIterator>>#basicNextAssociation has code to deal with empty pages
@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Oct 23, 2024 •
edited
Loading

SoilBTreeTest>>#testRemoveFromIndexAll tests the same for BTree

@MarcusDenker
Copy link
Contributor Author

I think:

  • index needs a basicRemoveKey (like current, remove the key from the index)
  • removeKey: has to check for empty and call removePage when page is empty

@MarcusDenker MarcusDenker self-assigned this Oct 23, 2024
@MarcusDenker MarcusDenker moved this to In Progress in Soil project board Oct 23, 2024
@MarcusDenker MarcusDenker moved this from In Progress to Todo in Soil project board Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusDenker MarcusDenker

Labels
None yet
Projects
Soil project board
Status: In Progress
Milestone
Index reuse of free pages
Development

No branches or pull requests
1 participant
@MarcusDenker