Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we need SoilIndexPage>>readHeaderFrom: #635

Open
MarcusDenker opened this issue Feb 20, 2024 · 1 comment
Open

Check if we need SoilIndexPage>>readHeaderFrom: #635

MarcusDenker opened this issue Feb 20, 2024 · 1 comment

Comments

@MarcusDenker
Copy link
Contributor

SoilIndexPage>>#writeHeaderOn: (and the same im all the subclasses) is nicely factored for header writing.

But we do not have the same design for readHeaderFrom: (it is used only for the SkipList Data page).
@MarcusDenker
Copy link
Contributor Author

It would be nice to have a symmetric readHeaderFrom: for every #writeHeaderOn:, but of course this is not really that important
(it would aide understanding an simplify changes in the future, I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Soil project board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcusDenker