Is FLAnimated Image Required

[dmiluski]

• I have checked Braze's documentation and am still experiencing the issue.

Report

I recently attempted to integrate with AppBoy via the instructions below:

binary "https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk.json"
github "rs/SDWebImage"
github "Flipboard/FLAnimatedImage"

And I'm getting a duplicate FLAnimatedImage since SDWebImage includes FLAnimatedImage? But If I drop FLAnimatedImage from the embedded frameworks (via submodule integration), dylib fails to be found?
https://github.com/rs/SDWebImage/tree/master/SDWebImage/FLAnimatedImage

If I include both Carthage dependencies: SDWebImage + FLAnimatedImage

Duplicate interface definition for class 'FLAnimatedImageView'

If I don't include FLAnimatedImage:

dyld: Library not loaded: @rpath/FLAnimatedImage.framework/FLAnimatedImage
  Referenced from: /Users/<username>/Library/Developer/CoreSimulator/Devices/<ID>/data/Containers/Bundle/Application/<AppID>/<Name>.app/Frameworks/Appboy_iOS_SDK.framework/Appboy_iOS_SDK
  Reason: image not found

Seeing if FLAnimatedImage library was still necessary as a separate dependency for Braze?

Describe your environment.

Info	Value
Platform Name	e.g. ios / tvos
Platform Version	e.g. 8.0
SDK Version	e.g. 3.7.6
Integration Method	e.g. carthage / cocoapods / manually
Xcode Version	e.g. Xcode 7.3
Repro rate	e.g. all the time (100%) / sometimes x% / only once

What did you do?

What did you expect to happen?

What happened instead?

Steps to reproduce

Code Snippet

Are you doing any feature customizations that may relate to the issue? Can you share the code snippet?

Project that demonstrates the issue

[chshapiro]

Hey @dmiluski,

Are you still experiencing this issue? Unfortunately, we were unable to reproduce and FLAnimatedImage is still required as a separate dependency.

Are you adding the frameworks in both the Embedded Binaries and Linked Frameworks and Libraries sections?

Thanks,
Chava

[dmiluski]

Hi @chshapiro , Our current integration was adding these dependencies via pre-build SDK you mention.

But, what I'm trying to do is integrate how you recently recommended.

Here's how our setup may be differing. For our default dependencies, we install as submodules for those eligible.

binary "https://raw.githubusercontent.com/Appboy/appboy-ios-sdk/master/appboy_ios_sdk.json"
github "rs/SDWebImage"
github "Flipboard/FLAnimatedImage"

// Install via Submodules
carthage bootstrap --no-build --use-ssh --use-submodules $@

// Install items which require binary spec
carthage build appboy_ios_sdk.json

It appears by doing this, during build SDWebImage and FLAnimatedImage are fighting b/c both own FLAnimatedImage?

[chshapiro]

@dmiluski,

Are you using Swift or Objective-C? There is a known SDWebImage issue (SDWebImage/SDWebImage#2279) that can happen when using Swift and Carthage.

Unfortunately, this is an SDWebImage issue that we can't do much about, but there is a workaround you can look at in #85.

Please let us know if you have any more questions.

Thanks,
Chava

[chshapiro]

Hey @dmiluski,

Are you still running into these issues?

Thanks,
Chava

[dmiluski]

Hi @chshapiro , yeah. Since SDWebImage 5 is still in beta, going to continue using AppBoy fat binary instead of thin binary until SDWebImage 5 is a full GM release.

[chshapiro]

Great! Once SdWebImage 5 is released, we are also looking into replacing our use of FLAnimatedImage with SDWebImage GIF support.

I'm going to close this issue for now. Feel free to reopen if you have further questions.