Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upload multiple artifacts" showing in read-only UI #4473

Closed
danielbobbert opened this issue Mar 21, 2024 · 3 comments
Closed

"Upload multiple artifacts" showing in read-only UI #4473

danielbobbert opened this issue Mar 21, 2024 · 3 comments
Assignees
Milestone

Comments

@danielbobbert
Copy link

danielbobbert commented Mar 21, 2024

Description

Registry
Version
: 2.5.10
Persistence type: any

Steps to Reproduce

If the UI is switched to read-only mode, the "Upload" button is properly hidden. But in the "..." menu, there is still an item for "Upload multiple artifacts"

Expected Behaviour

It the UI is switched to "read-only", the "Upload multiple artifacts" menu item should be removed from the "..." menu in the main "artifacts" UI page.

@danielbobbert danielbobbert added the type/bug Something isn't working label Mar 21, 2024
@apicurio-bot
Copy link

apicurio-bot bot commented Mar 21, 2024

Thank you for reporting an issue!

Pinging @EricWittmann to respond or triage.

@danielbobbert
Copy link
Author

I believe the problem is in the "import" DropdownItem in toolbar.tsx, where the item is added if "isAdmin=true", no matter what the "readOnly" state is.

@EricWittmann
Copy link
Member

Fixed in #4902

@github-project-automation github-project-automation bot moved this from In Progress to Done in Registry 3.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants