Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CORS env. variables #233

Open
jsenko opened this issue Aug 11, 2023 · 0 comments
Open

Improve CORS env. variables #233

jsenko opened this issue Aug 11, 2023 · 0 comments
Assignees

Comments

@jsenko
Copy link
Member

jsenko commented Aug 11, 2023

There are some CORS variables missing, and ALLOWED_ORIGINS should also include Keycloak URL.
Example:

- name: CORS_ALLOWED_ORIGINS
  value: >-
    http://keycloak-apicurio-registry-e2e.apps.rkubis13.apicurio.integration-qe.com,
    http://registry-apicurio-registry-e2e.apps.rkubis13.apicurio.integration-qe.com
- name: CORS_ALLOWED_METHODS
  value: 'GET,PUT,POST,PATCH,DELETE,OPTIONS'
- name: CORS_ALLOWED_HEADERS
  value: >-
    x-registry-name,x-registry-name-encoded,x-registry-description,x-registry-description-encoded,x-registry-version,x-registry-artifactid,x-registry-artifacttype,x-registry-hash-algorithm,x-registry-content-hash,access-control-request-method,access-control-allow-credentials,access-control-allow-origin,access-control-allow-headers,authorization,content-type
@jsenko jsenko self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant