Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness and Readiness probes not present in apicurio operator pods #144

Open
sidsj opened this issue Aug 3, 2021 · 4 comments
Open

Liveness and Readiness probes not present in apicurio operator pods #144

sidsj opened this issue Aug 3, 2021 · 4 comments
Assignees
Labels
Enhancement New feature or request

Comments

@sidsj
Copy link

sidsj commented Aug 3, 2021

The apicurio registry operator pod does not have liveness and readiness probes. Below is the configuration we have deployed:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: databus-apicurio-registry-operator
spec:
  replicas: 1
  selector:
    matchLabels:
      name: apicurio-registry-operator
  template:
    metadata:
      labels:
        name: apicurio-registry-operator
        apicur.io/type: operator
        apicur.io/name: apicurio-registry-operator
        apicur.io/version: 1.0.0-dev
    spec:
      serviceAccountName: apicurio-registry-operator
      containers:
        - name: apicurio-registry-operator
          # Replace this with the built image name
          image: {{.Values.apicurio.OPERATOR_IMAGE }}
          imagePullPolicy: Always
          resources:
            limits:
              memory: "64Mi"
              cpu: "4m"
            requests:
              memory: "32Mi"
              cpu: "2m"
          env:
            - name: REGISTRY_VERSION
              value: "2.0.x"
            - name: REGISTRY_IMAGE_MEM
              value: {{.Values.apicurio.REGISTRY_IMAGE_MEM }}
            - name: REGISTRY_IMAGE_STREAMS
              value: {{.Values.apicurio.REGISTRY_IMAGE_STREAMS }}
            - name: REGISTRY_IMAGE_SQL
              value: {{.Values.apicurio.REGISTRY_IMAGE_SQL }}
            - name: REGISTRY_IMAGE_INFINISPAN
              value: {{.Values.apicurio.REGISTRY_IMAGE_INFINISPAN }}
            - name: WATCH_NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
            - name: POD_NAME
              valueFrom:
                fieldRef:
                  fieldPath: metadata.name
            - name: POD_NAMESPACE
              valueFrom:
                fieldRef:
                  fieldPath: metadata.namespace
            - name: OPERATOR_NAME
              value: "apicurio-registry-operator"
@sidsj
Copy link
Author

sidsj commented Aug 16, 2021

Hi All, Is there any update on this issue ?

@sidsj
Copy link
Author

sidsj commented Aug 20, 2021

Is there any plan to provide liveness and readiness probes for apicurio operator pods ?

@EricWittmann EricWittmann added the Enhancement New feature or request label Aug 23, 2021
@EricWittmann
Copy link
Member

Hi @sidsj - thanks for opening this issue. We've got a lot of vacations going on right now, but I've triaged this and assigned it to the right people. Might be another week or two before we can get eyeballs on it.

@famarting
Copy link

as far as I know we have readiness and liveness probes in the various distributions of apicurio-registry-operator, i.e: this https://github.com/Apicurio/apicurio-registry-operator/blob/master/docs/resources/install.yaml or this https://github.com/Apicurio/apicurio-registry-operator/blob/master/config/manager/resources/manager.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants