Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all Safe versions in public use #29

Open
fubuloubu opened this issue Jan 29, 2024 · 2 comments
Open

Test all Safe versions in public use #29

fubuloubu opened this issue Jan 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@fubuloubu
Copy link
Member

Overview

Currently, we just support v1.3.0 in our test suite, we should ensure that our plugin works for v1.4.1, and potentially releases older than v1.3.0 (by first checking for usage of those older versions)

Specification

Add each version as a dependency here:
https://github.com/ApeWorX/ape-safe/blob/main/ape-config.yaml#L13

Then update the new versions here:
https://github.com/ApeWorX/ape-safe/blob/main/tests/conftest.py#L40

Dependencies

May need some Ape core updates for working with multiple versions of the same dependencies

@fubuloubu fubuloubu added the enhancement New feature or request label Jan 29, 2024
Copy link

linear bot commented Jan 29, 2024

@fubuloubu
Copy link
Member Author

Would also be good to check using fork chain to ensure that we replicate the same on-chain deployments that Safe is using (at least in an integration test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant