You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I delete an item from the grid (for instance, an image in a photo gallery), it seems to be thinking that element still exists and causes a "can't find .clientHeight of undefined" error.
This might have something to do with it storing children locally and then not looking for changes in children when an update occurs.
The text was updated successfully, but these errors were encountered:
I traced this further. We're pulling this.items, but we're not updating this value after this.props.children has changed even if everything else is being recomputed.
We end up in a situation like this where this.items has a null element:
A quick fix would be to filter out null elements from items in this.arrangeItems(). A proper fix would be to add another function which recomputes this.items after componentDidUpdate before initializing columns etc.
Maybe call this.renderChildren() first on componentDidUpdate?
If I delete an item from the grid (for instance, an image in a photo gallery), it seems to be thinking that element still exists and causes a "can't find
.clientHeight
of undefined" error.This might have something to do with it storing
children
locally and then not looking for changes inchildren
when an update occurs.The text was updated successfully, but these errors were encountered: