Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto-Profile] Treat invoked OS file selector as part of AntiMicroX to prevent profile switching when auto-profile is active #635

Open
1 task done
instinctualjealousy opened this issue Nov 30, 2022 · 1 comment
Labels
enhancement New feature or request Windows Windows-only issues

Comments

@instinctualjealousy
Copy link

instinctualjealousy commented Nov 30, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

(This is at least true on Windows, but I don't see why this wouldn't also affect other operating systems.)

If auto-profile is currently set to Active, and you use a Default profile for no-match scenarios- you're going to have a bad time with Save As and Load operations. My profile building is iterative, so I often clone profiles over with Save As and work on them for new games. Invoking Save As (or Load) when there's pending changes on a profile makes the no-match scenario invoke- prompting if I want to Save, Discard those changes, or Cancel entirely. This window will end up spawning above the Save As window. This feels like messy UX that could be prevented.

Describe the solution you'd like

In regard to all AntiMicroX-called OS file selector windows (Save As, Load, any others):

  • Detect these as child windows of AntiMicroX, therefore treat them the same as the Qt/native child windows
  • If not possible, at least disable auto-profile activation temporarily when clicking any of these buttons that invoke a file selector window (this would be a better version of what Xpadder does, which is to simply disable auto-profile any time you do manual file operations)
  • Another idea: disable auto-profile any time there are unsaved changes pending, re-enable when pending changes are saved

Describe alternatives you've considered

Deactivating auto-profile, editing and saving profiles, reactivating auto-profile. This is how it's always been and isn't ideal. It also seems if I'm willing to take the risk of it misbehaving, hitting Cancel on the window that pops to save pending changes seems to stop the profile-switch from occurring temporarily.

Additional context

No response


Upvote & Fund

  • If you find this issue important, mark it with 👍. It lets us see which fixes and features are demanded by the most users.
  • We're using Polar.sh so you can upvote and help fund this issue. It may incentivize some developers to contribute to this project and fix some bugs.
  • Funded developer receives the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@instinctualjealousy instinctualjealousy added the enhancement New feature or request label Nov 30, 2022
@instinctualjealousy instinctualjealousy changed the title [Auto-Profile] Treat invoked OS file selector as part of AntiMicroX (Save As, Load...) to prevent profile switching [Auto-Profile] Treat invoked OS file selector as part of AntiMicroX (Save As, Load...) to prevent profile switching when auto-profile is active Nov 30, 2022
@instinctualjealousy instinctualjealousy changed the title [Auto-Profile] Treat invoked OS file selector as part of AntiMicroX (Save As, Load...) to prevent profile switching when auto-profile is active [Auto-Profile] Treat invoked OS file selector as part of AntiMicroX to prevent profile switching when auto-profile is active Nov 30, 2022
@pktiuk pktiuk self-assigned this Dec 12, 2022
@pktiuk
Copy link
Member

pktiuk commented Jul 2, 2024

I am not sure whether implementing anything new related with autoprofile is worth the time.
Mainly because of lack of proper APIs on Wayland which is a new standard in most of the Linux distributions. #303

I think this feature can be considered Windows-only since now.

@pktiuk pktiuk added the Windows Windows-only issues label Jul 2, 2024
@pktiuk pktiuk removed their assignment Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Windows Windows-only issues
Projects
None yet
Development

No branches or pull requests

2 participants