Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Auto Profile #301

Closed
1 task done
Figuera opened this issue Nov 28, 2021 · 7 comments
Closed
1 task done

No Auto Profile #301

Figuera opened this issue Nov 28, 2021 · 7 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Figuera
Copy link

Figuera commented Nov 28, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Auto Profile tab on the Setting Menu ask me to select my desired Language:

2021-11-28_09-11-1638108502_partial

Expected Behavior

Auto Profile tab allow me to set which profile is loaded for each window.

Steps To Reproduce

1 - Go to Options > Settings > Auto Profile.

Environment

- OS: Arch Linux
- Display: Wayland
- Environment: Sway
- AntiMicroX version: 3.2 (Both packages in AUR were tested)

Anything else?

I wish I am being silly here and missing something obvious but I tried my best to get past that language selection screen to the actual Auto Profile Configuration and couldn't.


Upvote & Fund

  • If you find this issue important, mark it with 👍. It lets us see which fixes and features are demanded by the most users.
  • We're using Polar.sh so you can upvote and help fund this issue. It may incentivize some developers to contribute to this project and fix some bugs.
  • Funded developer receives the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Figuera Figuera added the bug Something isn't working label Nov 28, 2021
@pktiuk
Copy link
Member

pktiuk commented Nov 28, 2021

My first bet is lack of support for autoprofile feature in wayland.

I will have to check source code to be sure, but it seems to be the case

if(UNIX)
    if(WITH_X11)
        LIST(APPEND antimicrox_SOURCES src/x11extras.cpp
                src/qtx11keymapper.cpp
                src/unixcapturewindowutility.cpp
                src/autoprofilewatcher.cpp
                src/gui/capturedwindowinfodialog.cpp
                )
        LIST(APPEND antimicrox_HEADERS src/x11extras.h
                src/qtx11keymapper.h
                src/unixcapturewindowutility.h
                src/autoprofilewatcher.h
                src/gui/capturedwindowinfodialog.h
                )

        if(WITH_XTEST)

Only builds with enabled X11 support have this feature compiled, that's why I guess this feature is not meant for non X11 environments.

@Figuera
Copy link
Author

Figuera commented Nov 28, 2021

Maybe would be best to give a warning message then?

Also any advice on alternatives? Is there a command line option to change profiles?

@pktiuk
Copy link
Member

pktiuk commented Nov 28, 2021

Also any advice on alternatives? Is there a command line option to change profiles?

Yes. Check --help

  --profile <location>                Launch program with the configuration
                                      file selected as the default for selected
                                      controllers. Defaults to all controllers

Maybe would be best to give a warning message then?

Or implement for Wayland ;)
(I will decide later)

@pktiuk pktiuk self-assigned this Nov 28, 2021
@ArtechFuz3D-Studio
Copy link

ArtechFuz3D-Studio commented Nov 28, 2021 via email

@Figuera
Copy link
Author

Figuera commented Nov 28, 2021

Also any advice on alternatives? Is there a command line option to change profiles?

Yes. Check --help

  --profile <location>                Launch program with the configuration
                                      file selected as the default for selected
                                      controllers. Defaults to all controllers

Must confess that when I read this the first time I thought it would not work because it would try to launch antimicrox again, notice it was already running and fail. maybe rewrite the help message? No big deal, I should have tested but it might help others.

@pktiuk
Copy link
Member

pktiuk commented Nov 28, 2021

    if (QApplication::platformName() == QStringLiteral("xcb")) //xcb is the X11 plugin used on regular desktop Linux platforms    {
        populateAutoProfiles();
        fillAllAutoProfilesTable();
        fillGUIDComboBox();
    } else
    {
        delete ui->categoriesListWidget->item(2);
        ui->stackedWidget->removeWidget(ui->page_2);
    }

This is disabled for non-wayland sessions.

@pktiuk pktiuk added the wontfix This will not be worked on label Nov 28, 2021
@pktiuk
Copy link
Member

pktiuk commented Nov 28, 2021

This is not a bug, but functionality not implemented.

New issue for tracking implementation is here: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants