Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login.js Ln 58 #23

Open
walshe opened this issue Feb 7, 2018 · 6 comments
Open

Login.js Ln 58 #23

walshe opened this issue Feb 7, 2018 · 6 comments

Comments

@walshe
Copy link

walshe commented Feb 7, 2018

how come this line is missing 0 as mentioned in the tutorial

this.props.history.push("/");

@jayair
Copy link
Member

jayair commented Feb 9, 2018

@walshe Which line are you talking about in which part of the tutorial? Line 58 in Login.js is this one https://github.com/AnomalyInnovations/serverless-stack-demo-client/blob/master/src/containers/Login.js#L58.

@walshe
Copy link
Author

walshe commented Feb 10, 2018

yes line 58 in Login.js .. where has the this.props.history.push("/"); right after the user has been marked as authenticated?

@jayair
Copy link
Member

jayair commented Feb 12, 2018

@walshe I'm sorry I don't understand what you are saying. Can you elaborate?

@walshe
Copy link
Author

walshe commented Feb 12, 2018

what I am trying to say is this:

this line is missing in Login.js:
this.props.history.push("/")

@jayair
Copy link
Member

jayair commented Feb 17, 2018

@walshe No we don't need that line after we secure our pages. It's in this chapter - https://serverless-stack.com/chapters/redirect-on-login.html

@walshe
Copy link
Author

walshe commented Feb 18, 2018

ah I see :)

Btw, another question.. doesnt Cognito have some way of easily integrating default (but customizable) signup/login forms that be used in a web app (similar to auth0) so that a developer does not have to go to the trouble ? and if so would it be nice to add to the tutorial @jayair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants