Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live stream support #241

Closed
thaddeuskkr opened this issue Jan 12, 2021 · 9 comments · Fixed by #356
Closed

Live stream support #241

thaddeuskkr opened this issue Jan 12, 2021 · 9 comments · Fixed by #356

Comments

@thaddeuskkr
Copy link
Contributor

Hi, I have a quick question.

Are YouTube live streams not supported and if they are, why?

@twlite
Copy link
Collaborator

twlite commented Jan 12, 2021

Yes live videos are ignored
image

@thaddeuskkr
Copy link
Contributor Author

Yeah, but why tho?

@Androz2091
Copy link
Owner

Because this is not something we want to implement into discord-player, at least for the moment. It would be pretty complicated, like how to handle them in the queue? Will the users be able to add new songs after a live video? If so, will they be played after the live is finished?

@Androz2091 Androz2091 added enhancement New feature or request discussion labels Jan 16, 2021
@Edqe14
Copy link

Edqe14 commented Feb 7, 2021

I've worked on some music bots and for live videos isn't that much different from normal videos. Live videos will work normally when you feed it to ytdl, so the users still can put new songs to the queue since they technically still be able to skip the live video.

@twlite
Copy link
Collaborator

twlite commented Feb 7, 2021

Not only queue - it's hard to manage audio filters and stuff for live contents

@Edqe14
Copy link

Edqe14 commented Feb 8, 2021

@snowflake107 Can you tell/explain what is "stuff"? If audio filters cannot be used on live contents, just add a check if its live or not.

@devksingh4
Copy link

Currently, it only seems to play for the first 10 seconds, and then stops playing. I am under the impression that ytdl functionality is the same for normal videos and streams, so this is odd indeed

@M4X1MUS07
Copy link

Not only queue - it's hard to manage audio filters and stuff for live contents

Perform a check if its live and if it is just ignore Nightcore only. All other filters works for live streams except nightcore/speed changing filters. :feelsInvisibleMan:

@thaddeuskkr thaddeuskkr changed the title [ Question ] Live Streams Live stream support Mar 8, 2021
@twlite
Copy link
Collaborator

twlite commented Apr 14, 2021

bfed268

@twlite twlite linked a pull request Apr 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants