Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2 "Show 5-star Artifacts in the order of when they were obtained" Preventing Artifacts Scanning #537

Open
5 of 8 tasks
magiuu380 opened this issue Nov 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@magiuu380
Copy link

Current Behavior

After the 5.2 update, the in-game artifacts page had an extra option slider right in between the top menu bar and the first row of artifacts. This prevented the scanner from scanning the artifacts and it had led to multiple scanning sessions with 0 artifacts scanned.

Expected Behavior

The scanner continues to scan

Reproducing a Behavior

Paimon menu -> Inventory -> Artifacts: "Show 5-star Artifacts in the order of when they were obtained"
The newly added toggle switch from the 5.2 update prevents the scanner from locating the first and the subsequent artifacts.
This behavior happened every time after the 5.2 update, and only occurs when scanning artifacts. (scanning weapons and characters worked fine)

Device OS

Windows 11

Genshin Impact Version

5.2

Inventory Kamera Version

v1.3.16

Screen resolution, screen mode, and UI scale

1920x1080

Additional notes and remarks

No response

Evidence

No response

Preflight Checklist

  • I have checked for similar issues in the issue page, and I have not found any similar to mine.
  • I am using the latest version of the scanner.
  • I tried setting the scanning delay to maximum, and it still doesn't work.
  • I have attached the video recording to the bug report.
  • I have attached the error log to the bug report.
  • I am available to later explains the issue.
  • I have disabled (or documented) all screen filtering software, plugins, and enhancements while scanning.
  • I use default in-game keybindings or have configured keybindings for the scanner.
@magiuu380 magiuu380 added the bug Something isn't working label Nov 20, 2024
@dtung8068
Copy link

First time contributor here, but I think the issue can be fixed by adjusting the y and height values in ClearFilters() in ArtifactScraper. Unfortunately, I don't have the exact pixel measurements right now.

@taiwenlee
Copy link
Contributor

Pretty sure this is an issue with InventoryScraper.cs as the artifacts are screenshotted in there.

@taiwenlee
Copy link
Contributor

#540 made a pull request that hopefully fixes the issue without any additional bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants