Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Video not detected on ok.ru #51

Closed
ale5000-git opened this issue Dec 18, 2023 · 5 comments
Closed

[BUG] Video not detected on ok.ru #51

ale5000-git opened this issue Dec 18, 2023 · 5 comments
Labels
custom source pattern Custom source pattern required to work on website because it has a different file naming scheme

Comments

@ale5000-git
Copy link

Describe the bug
Video not detected

Version
FastStream V1.2.12

Platform
Firefox

Steps to Reproduce
Sample link: ok.ru/video/7803363133968
The video isn't detected so FastStream do not work at all on the sample link provided.

@Andrews54757
Copy link
Owner

Andrews54757 commented Dec 18, 2023

It seems like their website doesn't use the standard naming convention for stream manifests. Instead of URLs ending with a .m3u8 or .mpd they use a long query string:

https://vd343.mycdn.me/?expires=1702952511283&srcIp=[redacted]&pr=10&srcAg=CHROME_MAC&ms=[redacted]&type=1&sig=kThi2hIuDQE&ct=6&urls=[redacted]&clientType=0&zs=43&id=5978708576784

This is not detectable using FastStream as of this moment. It is not possible to detect this without having a hardcoded list of URL patterns. Since I don't plan on maintaining a fixed set of patterns, I will add a feature so that you can add custom patterns yourself.

Note: Having broad custom patterns may be computationally expensive.

@ale5000-git
Copy link
Author

I don't know the internal details of FastStream but can't generically detect all video elements in the DOM?

@Andrews54757
Copy link
Owner

Detecting the video element isn't the issue. The problem is that you need to detect the source of the video. This is detected by monitoring network requests. The DOM doesn't reveal information about the video source when it is a stream.

@Andrews54757
Copy link
Owner

Andrews54757 commented Dec 18, 2023

Custom source pattern support added 6500ee7

Go to settings and paste this into the custom source patterns text box.

# Custom pattern for ok.ru/video/
mpd /^https:\/\/vd[0-9]*\.mycdn\.me\/\?.*&type=1&/

@ale5000-git
Copy link
Author

It works perfectly, thanks.

@Andrews54757 Andrews54757 changed the title [BUG] Video not detected [BUG] Video not detected on ok.ru Dec 20, 2023
@Andrews54757 Andrews54757 added the custom source pattern Custom source pattern required to work on website because it has a different file naming scheme label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom source pattern Custom source pattern required to work on website because it has a different file naming scheme
Projects
None yet
Development

No branches or pull requests

2 participants