TouchEffect inside CollectionView DataTemplate not letting select item on Android

[Estevete]

Placing TouchEffect inside the DataTemplate of a CollectionView (I have tried Frame & Grid) does not work on Android.

I have tried by calling SelectionChangedCommand and doesn't work either.
I have tested on iOS and UWP and it works.

Repro link:
https://github.com/MADSENSE/Madsense.XamarinForms.Sample/tree/collection-view-frame-android-issue

[AndreiMisiukevich]

does it work with a content view?

[Estevete]

I have tried and no. It doesn't work either with a ContentView

[YZahringer]

I think it's not specific to CollectionView, TapGestureRecognizer does not work on any element with TouchEffect on Android

[AndreiMisiukevich]

So, probably this is the limitation of this package.
You should use TouchEff.Command for handling taps in CollectionView instead of default CollectionView's command.

[YZahringer]

@AndreiMisiukevich I think the problem is on e.Handled = true. Any reason to handle the event? This one is not handled on iOS and UWP.

TouchEffect/TouchEffect.Droid/PlatformTouchEff.cs

Lines 119 to 127 in f16d527

	private void OnTouch(object sender, AView.TouchEventArgs e)
	{
	if (_effect?.IsDisabled ?? true) return;
	if (IsAccessibilityMode)
	{
	return;
	}
	e.Handled = true;

[AndreiMisiukevich]

@AndreiMisiukevich I think the problem is on e.Handled = true. Any reason to handle the event? This one is not handled on iOS and UWP.

TouchEffect/TouchEffect.Droid/PlatformTouchEff.cs

Lines 119 to 127 in f16d527

	private void OnTouch(object sender, AView.TouchEventArgs e)
	{
	if (_effect?.IsDisabled ?? true) return;
	if (IsAccessibilityMode)
	{
	return;
	}
	e.Handled = true;

Hm, I thought it makes sense to mark the event as "handled" if it's handled indeed :)
Do you think we can safely remove this line?

[YZahringer]

I've done some tests and I don't see any issue without handling it. The e.Handled should be set to False, the default value is True.

I think the behavior should be the same on different platforms, the event should be handled on all or none. Currently is handled on Android but not on iOS or UWP.

I often define TouchEffect in a global Style, that's why I use GestureRecognizer in the element. It works well, TouchEffect provides visual states and the gestures execute the commands.

[AndreiMisiukevich]

I've done some tests and I don't see any issue without handling it. The e.Handled should be set to False, the default value is True.

I think the behavior should be the same on different platforms, the event should be handled on all or none. Currently is handled on Android but not on iOS or UWP.

I often define TouchEffect in a global Style, that's why I use GestureRecognizer in the element. It works well, TouchEffect provides visual states and the gestures execute the commands.

Well, if it works well even in the ScrollView sample, then I will appreciate submitting a PR with the fix :)
Would you like to do it?