Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dogfood #236

Open
lishaduck opened this issue Aug 25, 2024 · 1 comment
Open

Dogfood #236

lishaduck opened this issue Aug 25, 2024 · 1 comment
Labels
accepted The issue is accepted and a PR can be proposed. internals

Comments

@lishaduck
Copy link
Contributor

Turbo dislikes circular dependencies, which makes this difficult, but we should be able to lint the Sheriff monorepo using eslint-config-sheriff.
I was able to get it working for 99% of the repo in #162, but it's got a ton of conflicts now.
It's valuable that whenever we enforce something new, we have to feel it and decide if it's worth it ourselves.
@AndreaPontrandolfo AndreaPontrandolfo added accepted The issue is accepted and a PR can be proposed. internals labels Aug 25, 2024
@AndreaPontrandolfo
Copy link
Owner

It's unfortunate it got mangled by conflicts, the whole PR was pretty much perfect 😢

@lishaduck lishaduck mentioned this issue Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted The issue is accepted and a PR can be proposed. internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreaPontrandolfo @lishaduck