Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REPLACE] eslint-plugin-importeslint-plugin-import-x #200

Open
lishaduck opened this issue Aug 10, 2024 · 6 comments
Open

[REPLACE] eslint-plugin-importeslint-plugin-import-x #200

lishaduck opened this issue Aug 10, 2024 · 6 comments
Labels
accepted The issue is accepted and a PR can be proposed. good first issue Good for newcomers plugins

Comments

@lishaduck
Copy link
Contributor

lishaduck commented Aug 10, 2024

Neither one supports ESLint 9.
However, eslint-plugin-import-x is (subjectively) easier, (objectively) lighter weight, and (likely) faster.
I propose migrating, slapping a fixupPluginRules on it, and praying it works.

@AndreaPontrandolfo AndreaPontrandolfo added the triaging Issue is still being evaluated. PRs not yet accepted. label Aug 17, 2024
@AndreaPontrandolfo
Copy link
Owner

Heh, i'm kind of conflicted on this one.
After the work done in #208 and #219, all of our 7 eslint-plugin-import rules are now working correctly in ESLint v9.
I'm not exactly sure what tangible value eslint-plugin-import-x would provide for us right now.

I'll leave this issue up, so we track the progress of eslint-plugin-import-x and if it really get substantially ahead of eslint-plugin-import in some significative way, we'll make the switch.

@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 23, 2024

Oh, import-x merged ESLint 9/TSESLint 8 compat (not yet released though).
We don't need to fix what ain't broke, but just an fyi.

@lishaduck
Copy link
Contributor Author

Blocked on those other issues before considering this, but Sukka mentioned this in the last link: https://github.com/9romise/eslint-import-resolver-oxc
Looks sweet, if we do switch we might consider swapping out the resolver too.

@AndreaPontrandolfo
Copy link
Owner

I tested it. It is indeed 10X faster. But it's a very young project, so it's probably not worth it to switch now, too many things that could go wrong.
It's probably just better to wait for un-ts/eslint-plugin-import-x#150 and un-ts/eslint-plugin-import-x#40 and see if they implement it under-the-hood themselves.

@AndreaPontrandolfo
Copy link
Owner

AndreaPontrandolfo commented Dec 8, 2024

UPDATE: https://github.com/un-ts/eslint-plugin-import-x/releases/tag/v4.5.0

I think we can give eslint-plugin-import-x and eslint-import-resolver-oxc a try.

Im not putting this very high in my priorities list right now, but PRs on this are now accepted.

@AndreaPontrandolfo AndreaPontrandolfo added accepted The issue is accepted and a PR can be proposed. good first issue Good for newcomers and removed triaging Issue is still being evaluated. PRs not yet accepted. labels Dec 8, 2024
@lishaduck lishaduck moved this from Blocked to Todo in @lishaduck's todo list Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue is accepted and a PR can be proposed. good first issue Good for newcomers plugins
Projects
None yet
Development

No branches or pull requests

2 participants