Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Roll history to handle connection issues #59

Closed
AndreMiras opened this issue Apr 20, 2018 · 3 comments
Closed

Roll history to handle connection issues #59

AndreMiras opened this issue Apr 20, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@AndreMiras
Copy link
Owner

When having network issues while fetching roll history, the user should be notified and the application should not crash.
Currently the application exits because the py-etherscan-api library has some exits in the middle of the code, refs corpetty/py-etherscan-api#23
@AndreMiras AndreMiras added the bug Something isn't working label Apr 20, 2018
@AndreMiras
Copy link
Owner Author

The upstream pull request was merged recently, if this doesn't get a release/tag we'll take the update from master.

@AndreMiras
Copy link
Owner Author

Unfortunately we can't migrate to the new version because of corpetty/py-etherscan-api#27
We now need to way for corpetty/py-etherscan-api#28 to be merged 😞

@AndreMiras
Copy link
Owner Author

Fixed but not part of the automated ui testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreMiras