-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with animated draco #365
Comments
Hm, it's a bit hard to tell if this is a rendering bug or a pipeline bug. @FrankGalligan you might know better - if a model is draco-encoded and then draco-decoded will the indices stay in the same order? If not, I could see why there would be issues with Draco and morph targets together. |
So currently encoding a mesh with morph targets with default settings could cause errors as you observed. I'm going to make a change to gltf-pipeline to fix these types of files. The compression won't be as good as I'm going to force sequential encoding which will preserve the order. Later on, we will make changes to properly handle animation and morph targets. |
Check if the primitive contians any morph targets. If it does, set sequential encoding to preserve the order of vertices. This fixes CesiumGS#365
Fixed in #367
This error seems to have been fixed at some point in the meantime. |
Great, thanks guys for the quick fix! |
Hi,
So today I played some time with the new draco feature. Everything seemed to work fine, expect for when I tried to compress animated gltfs:
Without draco:
With draco:
The validator on donmccurdy's viewer says the following error:
Length of 0x004e4942 chunk is not aligned to 4-byte boundaries
When I export it as a
gltf+bin
(insteadglb
), the error is not showing up, but the visual artifact is the same. As well, as in the babylon sandbox. When I remove the-d
from the command, the exported file's animation works well, so I'm pretty sure draco has something to do with it.The command I use:
node bin/gltf-pipeline.js -i input/cube.gltf -s -d -b -o output/cube.glb
My files:
animation_test.zip
The text was updated successfully, but these errors were encountered: