Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display x y tiles on separate lines #8131

Merged

Conversation

chriswingler
Copy link
Contributor

@cesium-concierge
Copy link

Thanks for the pull request @chriswingler!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@chriswingler
Copy link
Contributor Author

Update: Looks like it's not working with IE11. I'm going to do a little investigating.

@OmarShehata
Copy link
Contributor

Thanks for this fix @chriswingler ! I haven't tested it out yet - what does it look like in IE11? Or does it not display at all?

@chriswingler
Copy link
Contributor Author

Thanks for this fix @chriswingler ! I haven't tested it out yet - what does it look like in IE11? Or does it not display at all?

@OmarShehata maybe I forgot to save, but it's working now in IE11. This PR is ready for review.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Looks great @chriswingler, thanks!

image

I'll merge as soon as CI passes

@hpinkos hpinkos merged commit 7c53a24 into CesiumGS:master Sep 18, 2019
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/?hl=en#!topic/cesium-dev/1rCMQGuwM-I

If this issue affects any of these threads, please post a comment like the following:

The issue at #8131 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

@chriswingler
Copy link
Contributor Author

Thank you @hpinkos !

@chriswingler chriswingler deleted the 8058-display-x-y-tiles-on-separate-lines branch September 20, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants