Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix particle image size #7412

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Fix particle image size #7412

merged 5 commits into from
Jan 3, 2019

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Dec 13, 2018

All particle systems using the default minimumImageSize and maximumImageSize were using the same Cartesian2 instance because we forgot to clone it.

@hpinkos hpinkos requested a review from ggetz December 13, 2018 19:33
@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor Author

hpinkos commented Dec 13, 2018

@mramato ready

@hpinkos
Copy link
Contributor Author

hpinkos commented Dec 18, 2018

@ggetz @mramato bump

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 2, 2019

Can someone merge this? @ggetz @mramato ?

@mramato
Copy link
Contributor

mramato commented Jan 2, 2019

Unit test?

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 2, 2019

@mramato ready

@mramato
Copy link
Contributor

mramato commented Jan 2, 2019

Thanks, I'll merge when green.

@mramato mramato merged commit 0d0e37a into master Jan 3, 2019
@mramato mramato deleted the particle-size branch January 3, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants