sampleHeight fixes and cleanup #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
commented
Oct 19, 2018
| @@ -3112,10 +3112,19 @@ define([ | |||
| this._lastRenderTime = JulianDate.clone(time, this._lastRenderTime); | |||
| this._renderRequested = false; | |||
| this._logDepthBufferDirty = false; | |||
| var frameNumber = CesiumMath.incrementWrap(frameState.frameNumber, 15000000.0, 1.0); | |||
| updateFrameNumber(this, frameNumber, time); | |||
There was a problem hiding this comment.
Separated updateFrameState and updateFrameNumber so that the frame number/time can be updated before update. In #7115 update is where async tiles get loaded so the frame number needs to be correct for the tileset cache to work properly.
lilleyse
force-pushed
the
offscreen-picking-prep
branch
from
ebd65d9 to
4b3bfbf
Compare
5 tasks
bagnell
reviewed
Oct 22, 2018
Source/Core/Ray.js
Outdated
| if (!defined(result)) { | ||
| return new Ray(ray.origin, ray.direction); | ||
| } | ||
| result.origin = ray.origin; |
There was a problem hiding this comment.
Here and below should clone ray.origin and ray.direction.
bagnell
reviewed
Oct 22, 2018
bagnell
reviewed
Oct 22, 2018
|
Those are the only comments. Looks good to me. |
|
@bagnell Thanks, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7120 and #7129
Otherwise most of this is organizational changes from #7115 that will make that PR easier to review later.
@bagnell can you review?