Fix applying translucent style to point cloud #6113
Conversation
|
@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
force-pushed
the
translucent-shader-update
branch
from
bae2977 to
e53672d
Compare
Source/Scene/Cesium3DTileStyle.js
Outdated
| @@ -1454,11 +1456,13 @@ define([ | |||
| Cesium3DTileStyle.prototype.getColorShaderFunction = function(functionName, attributePrefix, shaderState) { | |||
| if (this._colorShaderFunctionReady) { | |||
| // Return the cached result, may be undefined | |||
There was a problem hiding this comment.
Comment applies to next line, not this new line
Yeah, I'll need to create new sample tileset since all our test point clouds are a single tile. I'll bump when ready. |
|
Updated. |
|
@lilleyse It looks like that new test is failing. |
lilleyse
force-pushed
the
translucent-shader-update
branch
from
94d7113 to
38cfc31
Compare
|
Updated - it seems like it was a capitalization issue. Hopefully the test passes on Travis now. |
When setting a point cloud style's color to a translucent color only a single tile would become translucent. The fix is to mark whether the cached shader is translucent.