Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynamic polyline create the given arcType #8191

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Conversation

OmarShehata
Copy link
Contributor

@OmarShehata OmarShehata commented Sep 19, 2019

This is a fix for an issue that came up on the forum. It's easy to see in this Sandcastle.

The red line is a geodesic. The green is a rhumb. The dynamic blue line is supposed to be a rhumb line, but is always drawn as a geodesic no matter what you pass as an arcType.

bad_rhumb

This is because the dynamic polyline geometry does not take into account the arcType when generating the positions. I added a test to ensure this runs, which should fail in master and pass here.

@shehzan10

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@shehzan10
Copy link
Member

Seems fine to me. A maintainer should look at this and merge.

@OmarShehata
Copy link
Contributor Author

Thanks Shezhan! @hpinkos would you like to merge?

@hpinkos
Copy link
Contributor

hpinkos commented Sep 20, 2019

Reviewing this now

@hpinkos
Copy link
Contributor

hpinkos commented Sep 20, 2019

Works great @OmarShehata, thanks!

@hpinkos hpinkos merged commit 58624ba into master Sep 20, 2019
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/AmbEbLMKAAs/1OooENSyBgAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #8191 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

@hpinkos hpinkos deleted the dynamic-rhumb branch September 20, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants